From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Jeff Hostetler" <git@jeffhostetler.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"René Scharfe" <l.s.r@web.de>,
wink@saville.com, "Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Jeff Hostetler" <jeffhost@microsoft.com>
Subject: Re: [PATCH v4] json_writer: new routines to create data in JSON format
Date: Sat, 2 Jun 2018 01:13:45 -0400 [thread overview]
Message-ID: <20180602051344.GA28311@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8DcGp29iJDZKUz0JM-bvbE_G3KnqWyLk_efjd7T3URTYw@mail.gmail.com>
On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote:
> On Mon, Mar 26, 2018 at 4:31 PM, <git@jeffhostetler.com> wrote:
> > +static inline void assert_in_array(const struct json_writer *jw)
> > +{
> > + if (!jw->open_stack.len)
> > + die("json-writer: array: missing jw_array_begin()");
>
> When you reroll, please consider marking all these string for
> translation with _(), unless these are for machine consumption.
Actually, these are all basically asserts, I think. So ideally they'd be
BUG()s and not translated.
-Peff
next prev parent reply other threads:[~2018-06-02 5:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 14:31 [PATCH v4] routines to generate JSON data git
2018-03-26 14:31 ` [PATCH v4] json_writer: new routines to create data in JSON format git
2018-03-27 3:18 ` Ramsay Jones
2018-03-27 10:28 ` Jeff Hostetler
2018-03-27 15:45 ` Ramsay Jones
2018-03-27 17:14 ` Jeff Hostetler
2018-03-27 17:43 ` Wink Saville
2018-03-27 18:00 ` Randall S. Becker
2018-03-28 5:22 ` Junio C Hamano
2018-03-27 18:05 ` Ramsay Jones
2018-03-28 1:22 ` Junio C Hamano
2018-06-02 4:41 ` Duy Nguyen
2018-06-02 5:13 ` Jeff King [this message]
2018-06-04 9:41 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180602051344.GA28311@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=wink@saville.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).