From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Romain Merland" <merlorom@yahoo.fr>,
"Miguel Torroja" <miguel.torroja@gmail.com>,
viniciusalexandre@gmail.com,
"Lars Schneider" <larsxschneider@gmail.com>,
"Luke Diamand" <luke@diamand.org>
Subject: [PATCHv1 0/1] git-p4: better error reporting
Date: Tue, 5 Jun 2018 09:55:23 +0100 [thread overview]
Message-ID: <20180605085524.10838-1-luke@diamand.org> (raw)
If git-p4 cannot talk to the Perforce server, it will either give a
confusing error message, or just crash. Even I get tripped up by this.
This change just checks that the client can talk to the server, and in
particular that the user is logged in (the default login timeout is 12
hours).
It would be nice to also check for ticket expiration during long
Perforce operations, but this change does not attempt to do that.
Luke Diamand (1):
git-p4: better error reporting when p4 fails
git-p4.py | 55 +++++++++++++++++++++++++++++++++
t/t9833-errors.sh | 78 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 133 insertions(+)
create mode 100755 t/t9833-errors.sh
--
2.17.0.392.gdeb1a6e9b7
next reply other threads:[~2018-06-05 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 8:55 Luke Diamand [this message]
2018-06-05 8:55 ` [PATCHv1 1/1] git-p4: better error reporting when p4 fails Luke Diamand
[not found] ` <777690205.383623.1528195798488@mail.yahoo.com>
2018-06-05 10:59 ` Luke Diamand
2018-06-05 19:44 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605085524.10838-1-luke@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=merlorom@yahoo.fr \
--cc=miguel.torroja@gmail.com \
--cc=szeder.dev@gmail.com \
--cc=viniciusalexandre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).