git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] fsck: avoid looking at NULL blob->object
Date: Sat,  9 Jun 2018 11:50:14 +0200	[thread overview]
Message-ID: <20180609095014.17972-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20180609093141.GB8942@sigill.intra.peff.net>

> +test_expect_success 'fsck detects non-blob .gitmodules' '
> +	git init non-blob &&
> +	(
> +		cd non-blob &&
> +
> +		# As above, make the funny tree directly to avoid index
> +		# restrictions.
> +		mkdir subdir &&
> +		cp ../.gitmodules subdir/file &&
> +		git add subdir/file &&
> +		git commit -m ok &&
> +		tree=$(git ls-tree HEAD | sed s/subdir/.gitmodules/ | git mktree) &&

And $tree won't be used here, either.

> +
> +		test_must_fail git fsck 2>output &&
> +		grep gitmodulesBlob output
> +	)
> +'
> +
>  test_done
> -- 
> 2.18.0.rc1.446.g4486251e51
> 

      reply	other threads:[~2018-06-09  9:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-09  8:32 [PATCH] fsck: avoid looking at NULL blob->object Jeff King
2018-06-09  8:38 ` Eric Sunshine
2018-06-09  9:19   ` Jeff King
2018-06-09  8:45 ` Duy Nguyen
2018-06-09  9:20   ` Jeff King
2018-06-09  8:50 ` Martin Ågren
2018-06-09  9:21   ` Jeff King
2018-06-09 13:44     ` Martin Ågren
2018-06-12  9:51       ` Jeff King
2018-06-09  9:30 ` [PATCH v2 0/2] .gitmodules fsck cleanups Jeff King
2018-06-09  9:31   ` [PATCH v2 1/2] t7415: don't bother creating commit for symlink test Jeff King
2018-06-09  9:46     ` SZEDER Gábor
2018-06-11  8:35       ` [PATCH v3 0/2] .gitmodules fsck cleanups Jeff King
2018-06-11  8:35         ` [PATCH v3 1/2] t7415: don't bother creating commit for symlink test Jeff King
2018-06-11  8:35         ` [PATCH v3 2/2] fsck: avoid looking at NULL blob->object Jeff King
2018-06-09  9:31   ` [PATCH v2 " Jeff King
2018-06-09  9:50     ` SZEDER Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180609095014.17972-1-szeder.dev@gmail.com \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).