From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Bryan Turner <bturner@atlassian.com>,
Brandon Williams <bmwill@google.com>,
Ben Humphreys <behumphreys@atlassian.com>,
Git Users <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] Git v2.16.0-rc0
Date: Fri, 15 Jun 2018 03:26:20 -0400 [thread overview]
Message-ID: <20180615072620.GA841@sigill.intra.peff.net> (raw)
In-Reply-To: <20180615051321.GA5840@sigill.intra.peff.net>
On Fri, Jun 15, 2018 at 01:13:21AM -0400, Jeff King wrote:
> > The trouble is that GIT_SSH_VARIANT=simple is too... simple. You
> > would like a variant that passes in [-p port] [-4] [-6] as well. We
> > didn't implement that because we didn't have the attention of any
> > wrapper writer who wanted it; in absence of a potential user, we
> > decided to wait for a user to propose the interface they want. Now we
> > can celebrate, since that day has come.
>
> I'm not sure I'm celebrating. It seems like work for not much benefit.
> I'd just as soon use VARIANT=ssh and deal with any fallouts if my script
> does not behave exactly like openssh in all regards.
By the way, if this sounds like I'm crapping all over your ideas, I
really don't mean to. What I'm trying to say is that I think your
original patch may have hit a sweet spot between robustness and making
a simple-enough interface for users to configure.
-Peff
next prev parent reply other threads:[~2018-06-15 7:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 4:30 [ANNOUNCE] Git v2.16.0-rc0 Junio C Hamano
2017-12-29 7:17 ` Kaartic Sivaraam
2017-12-29 17:13 ` Paul Smith
2018-01-04 20:18 ` Thomas Gummerer
2018-01-04 21:35 ` Paul Smith
2018-01-03 3:34 ` Bryan Turner
2018-01-03 5:07 ` Jonathan Nieder
2018-01-03 5:41 ` Bryan Turner
2018-01-03 5:50 ` Jonathan Nieder
2018-01-03 21:15 ` Junio C Hamano
2018-01-03 5:35 ` Jonathan Nieder
2018-06-08 4:50 ` Jeff King
2018-06-12 16:29 ` Junio C Hamano
2018-06-14 18:30 ` Jeff King
2018-06-14 18:55 ` Jonathan Nieder
2018-06-14 19:39 ` Jeff King
2018-06-15 4:20 ` Jonathan Nieder
2018-06-15 5:13 ` Jeff King
2018-06-15 7:26 ` Jeff King [this message]
2018-01-04 20:33 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615072620.GA841@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=behumphreys@atlassian.com \
--cc=bmwill@google.com \
--cc=bturner@atlassian.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).