From: Kana Natsuno <dev@whileimautomaton.net>
To: git@vger.kernel.org
Cc: Kana Natsuno <dev@whileimautomaton.net>
Subject: [PATCH 2/2] userdiff: support new keywords in PHP hunk header
Date: Tue, 3 Jul 2018 22:15:40 +0900 [thread overview]
Message-ID: <20180703131540.60789-3-dev@whileimautomaton.net> (raw)
In-Reply-To: <20180703131540.60789-1-dev@whileimautomaton.net>
Recent version of PHP supports interface, trait, abstract class and
final class. This patch fixes the PHP hunk header regexp to support
all of these keywords.
Signed-off-by: Kana Natsuno <dev@whileimautomaton.net>
---
t/t4018/php-abstract-class | 4 ++++
t/t4018/php-final-class | 4 ++++
t/t4018/php-interface | 4 ++++
t/t4018/php-trait | 7 +++++++
userdiff.c | 2 +-
5 files changed, 20 insertions(+), 1 deletion(-)
create mode 100644 t/t4018/php-abstract-class
create mode 100644 t/t4018/php-final-class
create mode 100644 t/t4018/php-interface
create mode 100644 t/t4018/php-trait
diff --git a/t/t4018/php-abstract-class b/t/t4018/php-abstract-class
new file mode 100644
index 0000000..5213e12
--- /dev/null
+++ b/t/t4018/php-abstract-class
@@ -0,0 +1,4 @@
+abstract class RIGHT
+{
+ const FOO = 'ChangeMe';
+}
diff --git a/t/t4018/php-final-class b/t/t4018/php-final-class
new file mode 100644
index 0000000..69f5710
--- /dev/null
+++ b/t/t4018/php-final-class
@@ -0,0 +1,4 @@
+final class RIGHT
+{
+ const FOO = 'ChangeMe';
+}
diff --git a/t/t4018/php-interface b/t/t4018/php-interface
new file mode 100644
index 0000000..86b49ad
--- /dev/null
+++ b/t/t4018/php-interface
@@ -0,0 +1,4 @@
+interface RIGHT
+{
+ public function foo($ChangeMe);
+}
diff --git a/t/t4018/php-trait b/t/t4018/php-trait
new file mode 100644
index 0000000..65b8c82
--- /dev/null
+++ b/t/t4018/php-trait
@@ -0,0 +1,7 @@
+trait RIGHT
+{
+ public function foo($ChangeMe)
+ {
+ return 'foo';
+ }
+}
diff --git a/userdiff.c b/userdiff.c
index a69241b..36af25e 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -114,7 +114,7 @@ PATTERNS("perl",
"|<<|<>|<=>|>>"),
PATTERNS("php",
"^[\t ]*(((public|protected|private|static)[\t ]+)*function.*)$\n"
- "^[\t ]*(class.*)$",
+ "^[\t ]*((((final|abstract)[\t ]+)?class|interface|trait).*)$",
/* -- */
"[a-zA-Z_][a-zA-Z0-9_]*"
"|[-+0-9.e]+|0[xXbB]?[0-9a-fA-F]+"
--
2.10.1 (Apple Git-78)
prev parent reply other threads:[~2018-07-03 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 13:15 [PATCH 0/2] userdiff: support new keywords in PHP hunk header Kana Natsuno
2018-07-03 13:15 ` [PATCH 1/2] t4018: add missing test cases for PHP Kana Natsuno
2018-07-06 21:59 ` Junio C Hamano
2018-07-03 13:15 ` Kana Natsuno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703131540.60789-3-dev@whileimautomaton.net \
--to=dev@whileimautomaton.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).