Git development
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Kirill Smelkov <kirr@nexedi.com>
Subject: Re: [PATCH] t5500: prettify non-commit tag tests
Date: Tue, 3 Jul 2018 13:25:18 -0500	[thread overview]
Message-ID: <20180703182518.GA89464@syl.attlocal.net> (raw)
In-Reply-To: <20180703165518.GA29295@sigill.intra.peff.net>

On Tue, Jul 03, 2018 at 12:55:19PM -0400, Jeff King wrote:
> We don't need to use backslash continuation, as the "&&"
> already provides continuation (and happily soaks up empty
> lines between commands).

OK. That seems correct according to my recollection.

> We can also expand the multi-line printf into a
> here-document, which lets us use line breaks more naturally
> (and avoids another continuation that required us to break
> the natural indentation).

The patch below seems obviously correct to me, for what my $.02 is worth
:-).

> Signed-off-by: Jeff King <peff@peff.net>

Thanks,
Taylor

  reply	other threads:[~2018-07-03 18:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 16:55 [PATCH] t5500: prettify non-commit tag tests Jeff King
2018-07-03 18:25 ` Taylor Blau [this message]
2018-07-04  6:23 ` Kirill Smelkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703182518.GA89464@syl.attlocal.net \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kirr@nexedi.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox