From: Drew DeVault <sir@cmpwn.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] send-email: accept long lines with suitable transfer encoding
Date: Fri, 6 Jul 2018 08:26:04 -0400 [thread overview]
Message-ID: <20180706122604.GA9255@homura.localdomain> (raw)
In-Reply-To: <20180706022357.739657-3-sandals@crustytoothpaste.net>
On 2018-07-06 2:23 AM, brian m. carlson wrote:
> diff --git a/git-send-email.perl b/git-send-email.perl
> index a76953c310..4ea30c4070 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1899,6 +1899,10 @@ sub validate_patch {
> return $hook_error if $hook_error;
> }
>
> + # Any long lines will be automatically fixed if we use a suitable transfer
> + # encoding.
> + return if $xfer_encoding =~ /^(?:auto|quoted-printable|base64)$/;
Rather than returning in this case I'd sooner wrap the length check in
this test. If additional checks are added in the future it'd be too easy
to accidentally skip them if the transfer encoding is quoted-printable.
next prev parent reply other threads:[~2018-07-06 12:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 2:23 [PATCH 0/3] Automatic transfer encoding for patches brian m. carlson
2018-07-06 2:23 ` [PATCH 1/3] send-email: add an auto option for transfer encoding brian m. carlson
2018-07-06 6:01 ` Eric Sunshine
2018-07-06 20:19 ` brian m. carlson
2018-07-06 2:23 ` [PATCH 2/3] send-email: accept long lines with suitable " brian m. carlson
2018-07-06 6:08 ` Eric Sunshine
2018-07-06 12:26 ` Drew DeVault [this message]
2018-07-06 20:18 ` brian m. carlson
2018-07-06 2:23 ` [PATCH 3/3] send-email: automatically determine transfer-encoding brian m. carlson
2018-07-06 12:26 ` [PATCH 0/3] Automatic transfer encoding for patches Drew DeVault
2018-07-08 22:17 ` [PATCH v2 0/4] " brian m. carlson
2018-07-08 22:17 ` [PATCH v2 1/4] send-email: add an auto option for transfer encoding brian m. carlson
2018-07-08 22:17 ` [PATCH v2 2/4] send-email: accept long lines with suitable " brian m. carlson
2018-07-08 22:17 ` [PATCH v2 3/4] send-email: automatically determine transfer-encoding brian m. carlson
2018-07-08 22:17 ` [PATCH v2 4/4] docs: correct RFC specifying email line length brian m. carlson
2018-07-08 22:22 ` [PATCH v2 0/4] Automatic transfer encoding for patches Drew DeVault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706122604.GA9255@homura.localdomain \
--to=sir@cmpwn.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).