From: Jonathan Tan <jonathantanmy@google.com>
To: jonathantanmy@google.com
Cc: git@vger.kernel.org, git@jeffhostetler.com
Subject: Re: [PATCH 0/2] Avoiding errors when partial cloning a tagged blob
Date: Fri, 6 Jul 2018 12:38:47 -0700 [thread overview]
Message-ID: <20180706193847.160161-1-jonathantanmy@google.com> (raw)
In-Reply-To: <cover.1530905323.git.jonathantanmy@google.com>
> When cloning a repository with a tagged blob (like the Git repository)
> with --filter=blob:none, the following message appears:
>
> error: missing object referenced by 'refs/tags/junio-gpg-pub'
>
> and the resulting repository also fails fsck.
>
> Patch 1 fixes the protocol documentation and the server side of Git, and
> patch 2 makes clone error out when such a situation occurs.
>
> An argument could be made that we should not merge patch 2 just yet due
> to the fact that some server implementations (such as Git and JGit)
> still exhibit the old behavior, and the resulting clones (albeit failing
> fsck) are still usable, because when attempting to load the blob, Git
> will automatically fetch it. I'm on the fence about this, and have
> included patch 2 in this patch set nevertheless for completeness.
>
> Jonathan Tan (2):
> upload-pack: send refs' objects despite "filter"
> clone: check connectivity even if clone is partial
Forgot to mention: this patch set is based on bw/ref-in-want because I
needed its one-time-sed functionality.
next prev parent reply other threads:[~2018-07-06 19:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 19:34 [PATCH 0/2] Avoiding errors when partial cloning a tagged blob Jonathan Tan
2018-07-06 19:34 ` [PATCH 1/2] upload-pack: send refs' objects despite "filter" Jonathan Tan
2018-07-06 19:34 ` [PATCH 2/2] clone: check connectivity even if clone is partial Jonathan Tan
2018-07-06 19:38 ` Jonathan Tan [this message]
2018-07-06 20:10 ` [PATCH 0/2] Avoiding errors when partial cloning a tagged blob Junio C Hamano
2018-07-06 21:25 ` Jonathan Tan
2018-07-06 21:29 ` Jonathan Nieder
2018-07-06 22:18 ` Junio C Hamano
2018-07-09 16:07 ` Junio C Hamano
2018-07-09 17:10 ` Jonathan Tan
2018-07-09 19:33 ` Junio C Hamano
2018-07-09 20:07 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706193847.160161-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).