From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org, gitster@pobox.com
Cc: Stefan Beller <sbeller@google.com>
Subject: [PATCHv5 0/9] Reroll of sb/diff-color-move-more
Date: Mon, 16 Jul 2018 16:05:33 -0700 [thread overview]
Message-ID: <20180716230542.81372-1-sbeller@google.com> (raw)
This is a resend of sb/diff-color-move-more
https://public-inbox.org/git/20180629001958.85143-1-sbeller@google.com/
that fixes an errornous squashing within the series; the end result is
the same. range diff is below. (As the latest cooking email said
this series is going to land in next soon, I hope this is not too late
of a resend; otherwise just ignore it as the end result is the same)
Thanks,
Stefan
Stefan Beller (9):
xdiff/xdiff.h: remove unused flags
xdiff/xdiffi.c: remove unneeded function declarations
t4015: avoid git as a pipe input
diff.c: do not pass diff options as keydata to hashmap
diff.c: adjust hash function signature to match hashmap expectation
diff.c: add a blocks mode for moved code detection
diff.c: decouple white space treatment from move detection algorithm
diff.c: factor advance_or_nullify out of mark_color_as_moved
diff.c: add white space mode to move detection that allows indent
changes
Documentation/diff-options.txt | 30 +++-
diff.c | 253 +++++++++++++++++++++++++++++----
diff.h | 9 +-
t/t4015-diff-whitespace.sh | 243 ++++++++++++++++++++++++++-----
xdiff/xdiff.h | 8 --
xdiff/xdiffi.c | 17 ---
6 files changed, 472 insertions(+), 88 deletions(-)
--
2.18.0.203.gfac676dfb9-goog
1: 7199e9b5608 ! 1: 7d58ad461cb diff.c: decouple white space treatment from move detection algorithm
@@ -207,9 +207,8 @@
+ EOF
+
+ # Make sure we get a different diff using -w
-+ git diff --color --color-moved -w |
-+ grep -v "index" |
-+ test_decode_color >actual &&
++ git diff --color --color-moved -w >actual.raw &&
++ grep -v "index" actual.raw | test_decode_color >actual &&
+ q_to_tab <<-\EOF >expected &&
+ <BOLD>diff --git a/text.txt b/text.txt<RESET>
+ <BOLD>--- a/text.txt<RESET>
@@ -224,9 +223,8 @@
+
+ # And now ignoring white space only in the move detection
+ git diff --color --color-moved \
-+ --color-moved-ws=ignore-all-space,ignore-space-change,ignore-space-at-eol |
-+ grep -v "index" |
-+ test_decode_color >actual &&
++ --color-moved-ws=ignore-all-space,ignore-space-change,ignore-space-at-eol >actual.raw &&
++ grep -v "index" actual.raw | test_decode_color >actual &&
+ q_to_tab <<-\EOF >expected &&
+ <BOLD>diff --git a/text.txt b/text.txt<RESET>
+ <BOLD>--- a/text.txt<RESET>
2: 5626d523b70 = 2: f08353f2a02 diff.c: factor advance_or_nullify out of mark_color_as_moved
3: e2f1e573699 ! 3: 3fde7cf2194 diff.c: add white space mode to move detection that allows indent changes
@@ -339,30 +339,6 @@
diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
--- a/t/t4015-diff-whitespace.sh
+++ b/t/t4015-diff-whitespace.sh
-@@
- EOF
-
- # Make sure we get a different diff using -w
-- git diff --color --color-moved -w |
-- grep -v "index" |
-- test_decode_color >actual &&
-+ git diff --color --color-moved -w >actual.raw &&
-+ grep -v "index" actual.raw | test_decode_color >actual &&
- q_to_tab <<-\EOF >expected &&
- <BOLD>diff --git a/text.txt b/text.txt<RESET>
- <BOLD>--- a/text.txt<RESET>
-@@
-
- # And now ignoring white space only in the move detection
- git diff --color --color-moved \
-- --color-moved-ws=ignore-all-space,ignore-space-change,ignore-space-at-eol |
-- grep -v "index" |
-- test_decode_color >actual &&
-+ --color-moved-ws=ignore-all-space,ignore-space-change,ignore-space-at-eol >actual.raw &&
-+ grep -v "index" actual.raw | test_decode_color >actual &&
- q_to_tab <<-\EOF >expected &&
- <BOLD>diff --git a/text.txt b/text.txt<RESET>
- <BOLD>--- a/text.txt<RESET>
@@
test_cmp expected actual
'
next reply other threads:[~2018-07-16 23:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 23:05 Stefan Beller [this message]
2018-07-16 23:05 ` [PATCH 1/9] xdiff/xdiff.h: remove unused flags Stefan Beller
2018-07-16 23:05 ` [PATCH 2/9] xdiff/xdiffi.c: remove unneeded function declarations Stefan Beller
2018-07-16 23:05 ` [PATCH 3/9] t4015: avoid git as a pipe input Stefan Beller
2018-07-16 23:05 ` [PATCH 4/9] diff.c: do not pass diff options as keydata to hashmap Stefan Beller
2018-07-16 23:05 ` [PATCH 5/9] diff.c: adjust hash function signature to match hashmap expectation Stefan Beller
2018-07-16 23:05 ` [PATCH 6/9] diff.c: add a blocks mode for moved code detection Stefan Beller
2018-07-16 23:05 ` [PATCH 7/9] diff.c: decouple white space treatment from move detection algorithm Stefan Beller
2018-07-16 23:05 ` [PATCH 8/9] diff.c: factor advance_or_nullify out of mark_color_as_moved Stefan Beller
2018-07-16 23:05 ` [PATCH 9/9] diff.c: add white space mode to move detection that allows indent changes Stefan Beller
2018-07-18 18:25 ` Andrei Rybak
2018-07-18 18:27 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716230542.81372-1-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).