git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
	"Henning Schild" <henning.schild@siemens.com>,
	git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Martin Ågren" <martin.agren@gmail.com>,
	"Ben Toews" <mastahyeti@gmail.com>,
	"Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH v3 1/7] gpg-interface: add new config to select how to sign a commit
Date: Mon, 16 Jul 2018 20:55:17 -0400	[thread overview]
Message-ID: <20180717005517.GA23398@sigill.intra.peff.net> (raw)
In-Reply-To: <20180717000310.GA980821@genre.crustytoothpaste.net>

On Tue, Jul 17, 2018 at 12:03:11AM +0000, brian m. carlson wrote:

> > +gpg.format::
> > +	Specifies which key format to use when signing with `--gpg-sign`.
> > +	Default is "openpgp", that is also the only supported value.
> 
> I think, as discussed in the other thread, perhaps a different prefix
> for these options is in order if we'd like to plan for the future.
> Maybe this could be "signature.format", "sign.format", "signing.format",
> or "signingtool.format" (I tend to prefer the former, but not too
> strongly).
> 
> I anticipate that some projects will prefer other formats, and it makes
> it easier if we don't have to maintain two sets of legacy names.

Heh. This is slowly morphing into the original signingtool series.

For the record (since I think my response is what you meant by the
"other thread"), I'm OK with going down this gpg.* road for now, and
dealing with other tools if and when they appear (via the extra level of
indirection).

-Peff

  reply	other threads:[~2018-07-17  0:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  8:41 [PATCH v3 0/7] X509 (gpgsm) commit signing support Henning Schild
2018-07-13  8:41 ` [PATCH v3 1/7] gpg-interface: add new config to select how to sign a commit Henning Schild
2018-07-16 20:14   ` Junio C Hamano
2018-07-16 21:38     ` Jeff King
2018-07-17 12:50     ` Henning Schild
2018-07-17  0:03   ` brian m. carlson
2018-07-17  0:55     ` Jeff King [this message]
2018-07-13  8:41 ` [PATCH v3 2/7] t/t7510: check the validation of the new config gpg.format Henning Schild
2018-07-16 20:15   ` Junio C Hamano
2018-07-13  8:41 ` [PATCH v3 3/7] gpg-interface: introduce an abstraction for multiple gpg formats Henning Schild
2018-07-16 20:40   ` Junio C Hamano
2018-07-17 12:50     ` Henning Schild
2018-07-13  8:41 ` [PATCH v3 4/7] gpg-interface: do not hardcode the key string len anymore Henning Schild
2018-07-16 20:40   ` Junio C Hamano
2018-07-13  8:41 ` [PATCH v3 5/7] gpg-interface: introduce new config to select per gpg format program Henning Schild
2018-07-16 20:45   ` Junio C Hamano
2018-07-17 12:50     ` Henning Schild
2018-07-13  8:41 ` [PATCH v3 6/7] gpg-interface: introduce new signature format "x509" using gpgsm Henning Schild
2018-07-13  8:41 ` [PATCH v3 7/7] gpg-interface t: extend the existing GPG tests with GPGSM Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717005517.GA23398@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=henning.schild@siemens.com \
    --cc=martin.agren@gmail.com \
    --cc=mastahyeti@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).