From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/6] use size_t in iconv/strbuf
Date: Tue, 24 Jul 2018 06:48:52 -0400 [thread overview]
Message-ID: <20180724104852.GA14638@sigill.intra.peff.net> (raw)
This series is primarily about the first two patches to convert our
iconv helpers to use size_t consistently. I posted them to the
git-security list a while back, wondering if there was something sneaky
you could do here. But after some discussion, the consensus was no, you
can't.
The other four patches are just semi-related cleanups I saw while poking
around the strbuf code. I doubt any of them fixes a user-visible bug,
but I think they're worth doing (and they don't seem to conflict with
anything on pu).
[1/6]: reencode_string: use st_add/st_mult helpers
[2/6]: reencode_string: use size_t for string lengths
[3/6]: strbuf: use size_t for length in intermediate variables
[4/6]: strbuf_readlink: use ssize_t
[5/6]: pass st.st_size as hint for strbuf_readlink()
[6/6]: strbuf_humanise: use unsigned variables
builtin/init-db.c | 3 ++-
convert.c | 6 +++---
pretty.c | 2 +-
refs/files-backend.c | 2 +-
strbuf.c | 20 ++++++++++----------
utf8.c | 10 +++++-----
utf8.h | 10 +++++-----
7 files changed, 27 insertions(+), 26 deletions(-)
-Peff
next reply other threads:[~2018-07-24 10:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 10:48 Jeff King [this message]
2018-07-24 10:50 ` [PATCH 1/6] reencode_string: use st_add/st_mult helpers Jeff King
2018-07-24 10:50 ` [PATCH 2/6] reencode_string: use size_t for string lengths Jeff King
2018-07-24 10:51 ` [PATCH 3/6] strbuf: use size_t for length in intermediate variables Jeff King
2018-07-24 10:51 ` [PATCH 4/6] strbuf_readlink: use ssize_t Jeff King
2018-07-24 10:51 ` [PATCH 5/6] pass st.st_size as hint for strbuf_readlink() Jeff King
2018-07-25 18:41 ` Torsten Bögershausen
2018-07-26 6:09 ` Jeff King
2018-07-24 10:52 ` [PATCH 6/6] strbuf_humanise: use unsigned variables Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724104852.GA14638@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).