From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1608F1F597 for ; Thu, 26 Jul 2018 07:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728620AbeGZIkB (ORCPT ); Thu, 26 Jul 2018 04:40:01 -0400 Received: from cloud.peff.net ([104.130.231.41]:59744 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727742AbeGZIkB (ORCPT ); Thu, 26 Jul 2018 04:40:01 -0400 Received: (qmail 21879 invoked by uid 109); 26 Jul 2018 07:24:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 26 Jul 2018 07:24:31 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 14211 invoked by uid 111); 26 Jul 2018 07:24:31 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Thu, 26 Jul 2018 03:24:31 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 26 Jul 2018 03:24:29 -0400 Date: Thu, 26 Jul 2018 03:24:29 -0400 From: Jeff King To: Junio C Hamano Cc: git@vger.kernel.org Subject: Re: What's cooking in git.git (Jul 2018, #03; Wed, 25) Message-ID: <20180726072429.GA7625@sigill.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Jul 25, 2018 at 03:13:37PM -0700, Junio C Hamano wrote: > * jk/banned-function (2018-07-24) 5 commits > - banned.h: mark strncpy() as banned > - banned.h: mark sprintf() as banned > - banned.h: mark strcat() as banned > - automatically ban strcpy() > - Merge branch 'sb/blame-color' into jk/banned-function > > It is too easy to misuse system API functions such as strcat(); > these selected functions are now forbidden in this codebase and > will cause a compilation failure. > > Will merge to 'next'. Eric nudged me over the fence to use a slightly different mechanism to generate the error. See: https://public-inbox.org/git/20180726072105.GA6057@sigill.intra.peff.net/ It looks like sb/blame-color graduated, so this could also just be applied directly on master now to avoid the funky merge. -Peff