git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Vojtech Myslivec <vojtech.myslivec@nic.cz>
Cc: git@vger.kernel.org, "Karel Kočí" <karel.koci@nic.cz>
Subject: Re: [PATCH 1/1] verify-tag/verify-commit should exit unsuccessfully when signature is not trusted
Date: Wed, 1 Aug 2018 00:19:42 +0000	[thread overview]
Message-ID: <20180801001942.GC45452@genre.crustytoothpaste.net> (raw)
In-Reply-To: <09f9803c-3f4b-a97c-2c59-e9d6b924892f@nic.cz>

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On Tue, Jul 31, 2018 at 10:05:22PM +0200, Vojtech Myslivec wrote:
> Hello,
> 
> me and my colleague are struggling with automation of verifying git
> repositories and we have encountered that git verify-commit and
> verify-tag accepts untrusted signatures and exit successfully.

I don't have strong feelings on your change one way or the other, but
for automation it may be useful to use the --raw flag, which gives you
the raw gpg output and much greater control.  For example, you can
require that a subkey is or is not used or require certain algorithms.

I will say that most signatures are untrusted in my experience, so
unless people are using TOFU mode or making local signatures, git will
exit nonzero for most signatures.  I think the current status is to exit
on a good signature, even if it isn't necessarily a valid signature.

I'm interested to hear others' thoughts on this.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]

  reply	other threads:[~2018-08-01  0:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 20:05 [PATCH 1/1] verify-tag/verify-commit should exit unsuccessfully when signature is not trusted Vojtech Myslivec
2018-08-01  0:19 ` brian m. carlson [this message]
2018-08-01  0:25   ` Santiago Torres
2018-08-03 13:36     ` Karel Kočí
2018-08-03 15:43       ` Santiago Torres
2018-08-03 16:06         ` Jeff King
2018-08-04  8:43           ` Karel Kočí
2018-08-08 23:04             ` Jeff King
2018-08-08 23:12               ` brian m. carlson
2018-08-09  0:59                 ` Junio C Hamano
2018-08-09  1:43                   ` brian m. carlson
2018-08-09 14:30                     ` Jeff King
2018-08-09 15:30                       ` Junio C Hamano
2018-08-09 17:12                         ` Jeff King
2018-08-09 18:40                           ` Junio C Hamano
2018-08-09 19:50                             ` Jeff King
2018-08-10  2:27                             ` brian m. carlson
2018-08-13 15:14                             ` Vojtech Myslivec
2018-08-03 17:32         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801001942.GC45452@genre.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=karel.koci@nic.cz \
    --cc=vojtech.myslivec@nic.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).