From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A0B961F404 for ; Fri, 10 Aug 2018 23:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727441AbeHKBj1 (ORCPT ); Fri, 10 Aug 2018 21:39:27 -0400 Received: from cloud.peff.net ([104.130.231.41]:50646 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727256AbeHKBj0 (ORCPT ); Fri, 10 Aug 2018 21:39:26 -0400 Received: (qmail 27889 invoked by uid 109); 10 Aug 2018 23:07:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 10 Aug 2018 23:07:31 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 24583 invoked by uid 111); 10 Aug 2018 23:07:33 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Fri, 10 Aug 2018 19:07:33 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 10 Aug 2018 19:07:29 -0400 Date: Fri, 10 Aug 2018 19:07:29 -0400 From: Jeff King To: git@vger.kernel.org Cc: Jonathan Tan Subject: [PATCH 0/7] speeding up cat-file by reordering object access Message-ID: <20180810230729.GA19090@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org This series is meant to replace the RFC discussion in: https://public-inbox.org/git/20180808231210.242120-1-jonathantanmy@google.com/ and https://public-inbox.org/git/20180808155045.GB1607@sigill.intra.peff.net/ The general idea is that accessing objects in packfile order is way kinder to the delta base cache, and thus way more efficient. See patches 4 and 7 in particular for discussion and numbers. I'm primarily interested in cat-file, so this series is focused there. But there may be other callers of for_each_packed_object() who could benefit. Most of the existing ones just care about getting the oid, so they're better off as-is. It's possible the call in is_promisor_object() could benefit, since it calls parse_object() on each entry it visits. I didn't experiment with it. [1/7]: for_each_*_object: store flag definitions in a single location [2/7]: for_each_*_object: take flag arguments as enum [3/7]: for_each_*_object: give more comprehensive docstrings [4/7]: for_each_packed_object: support iterating in pack-order [5/7]: t1006: test cat-file --batch-all-objects with duplicates [6/7]: cat-file: rename batch_{loose,packed}_object callbacks [7/7]: cat-file: support "unordered" output for --batch-all-objects Documentation/git-cat-file.txt | 8 ++++ builtin/cat-file.c | 70 ++++++++++++++++++++++++++++------ cache.h | 29 +++++++++++--- commit-graph.c | 2 +- packfile.c | 24 +++++++++--- packfile.h | 23 ++++++----- sha1-file.c | 3 +- t/t1006-cat-file.sh | 17 ++++++++- 8 files changed, 139 insertions(+), 37 deletions(-) -Peff