* function get_delta_base() is a file-local symbol
@ 2018-08-12 0:30 Ramsay Jones
2018-08-12 1:16 ` Jeff King
0 siblings, 1 reply; 3+ messages in thread
From: Ramsay Jones @ 2018-08-12 0:30 UTC (permalink / raw)
To: Christian Couder; +Cc: Jeff King, GIT Mailing-list
Hi Christian,
My static-check.pl script has pinged me about the get_delta_base()
symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
branch exports this symbol, saying that it will soon be called from
outside packfile.c. As far as I can tell, no other patch in that series
adds any such call.
Do you have plans to extend that series with additional patches which
will add such calls?
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: function get_delta_base() is a file-local symbol
2018-08-12 0:30 function get_delta_base() is a file-local symbol Ramsay Jones
@ 2018-08-12 1:16 ` Jeff King
2018-08-12 3:53 ` Christian Couder
0 siblings, 1 reply; 3+ messages in thread
From: Jeff King @ 2018-08-12 1:16 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Christian Couder, GIT Mailing-list
On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:
> Hi Christian,
>
> My static-check.pl script has pinged me about the get_delta_base()
> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
> branch exports this symbol, saying that it will soon be called from
> outside packfile.c. As far as I can tell, no other patch in that series
> adds any such call.
>
> Do you have plans to extend that series with additional patches which
> will add such calls?
Hmm, I think this is just my error. I had to untangle the delta island
code from a few other topics, and I think I mistakenly attributed the
need for get_delta_base() to the wrong topic. It can just be left alone
for this series.
-Peff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: function get_delta_base() is a file-local symbol
2018-08-12 1:16 ` Jeff King
@ 2018-08-12 3:53 ` Christian Couder
0 siblings, 0 replies; 3+ messages in thread
From: Christian Couder @ 2018-08-12 3:53 UTC (permalink / raw)
To: Jeff King, Ramsay Jones; +Cc: Christian Couder, GIT Mailing-list
Hi Ramsay and Peff,
On Sun, Aug 12, 2018 at 3:16 AM, Jeff King <peff@peff.net> wrote:
> On Sun, Aug 12, 2018 at 01:30:02AM +0100, Ramsay Jones wrote:
>
>> My static-check.pl script has pinged me about the get_delta_base()
>> symbol from packfile.[co]. The first patch from your 'cc/delta-islands'
>> branch exports this symbol, saying that it will soon be called from
>> outside packfile.c. As far as I can tell, no other patch in that series
>> adds any such call.
Yeah, I should have checked that but I didn't.
Thanks for noticing.
>> Do you have plans to extend that series with additional patches which
>> will add such calls?
>
> Hmm, I think this is just my error. I had to untangle the delta island
> code from a few other topics, and I think I mistakenly attributed the
> need for get_delta_base() to the wrong topic. It can just be left alone
> for this series.
Ok, I will will remove the first patch in the next reroll. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-12 3:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-12 0:30 function get_delta_base() is a file-local symbol Ramsay Jones
2018-08-12 1:16 ` Jeff King
2018-08-12 3:53 ` Christian Couder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).