From: Jeff King <peff@peff.net>
To: Stas Bekman <stas@stason.org>
Cc: git@vger.kernel.org
Subject: Re: GIT_TRACE doesn't show content filter files it's operating on
Date: Mon, 27 Aug 2018 20:58:10 -0400 [thread overview]
Message-ID: <20180828005810.GA18659@sigill.intra.peff.net> (raw)
In-Reply-To: <28045b26-4822-b00c-30f3-1076d2e49d1f@stason.org>
On Mon, Aug 27, 2018 at 05:22:13PM -0700, Stas Bekman wrote:
> Your suggestions do the trick, Jeff. Thank you.
>
> 1. To benefit others who might be looking for something similar may I
> post your suggestions as an answer to:
> <https://stackoverflow.com/questions/51995773/getting-git-to-show-specific-filenames-it-is-running-content-filters-on>?
Great, thanks.
> 2. Is there no way to get git to do the filename reporting as a normal
> GIT_TRACE behavior? I don't know anything about its internal workings,
> but it surely must knows which file it operates on when it opens it and
> sends its data as stdin to the content filter. It makes the debugging so
> much easier when one can see what files are being worked on. So perhaps
> this utility can be made available to all not just as a hack/workaround.
No, because GIT_TRACE itself only reports on the execution of commands
and sub-processes. There are other GIT_TRACE_* variables for various
subsystems, but AFAIK nobody has instrumented the smudge/clean filter
code. IMHO it would be reasonable to have a GIT_TRACE_CONVERT
that covered convert.c (so these filters, but also newline conversion,
etc).
-Peff
next prev parent reply other threads:[~2018-08-28 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 23:23 GIT_TRACE doesn't show content filter files it's operating on Stas Bekman
2018-08-27 23:53 ` Jeff King
2018-08-28 0:22 ` Stas Bekman
2018-08-28 0:58 ` Jeff King [this message]
2018-08-28 1:13 ` Stas Bekman
2018-08-28 19:44 ` Stas Bekman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828005810.GA18659@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=stas@stason.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).