From: Jann Horn <jannh@google.com>
To: git@vger.kernel.org, jannh@google.com
Cc: gitster@pobox.com, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Jeff King" <peff@peff.net>, "Nicolas Pitre" <nico@cam.org>
Subject: [PATCH 3/3] t5303: add tests for corrupted deltas
Date: Wed, 29 Aug 2018 22:58:57 +0200 [thread overview]
Message-ID: <20180829205857.77340-3-jannh@google.com> (raw)
In-Reply-To: <20180829205857.77340-1-jannh@google.com>
This verifies the changes from commit "patch-delta: fix oob read".
Signed-off-by: Jann Horn <jannh@google.com>
---
t/t5303-pack-corruption-resilience.sh | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corruption-resilience.sh
index 3634e258f..7152376b6 100755
--- a/t/t5303-pack-corruption-resilience.sh
+++ b/t/t5303-pack-corruption-resilience.sh
@@ -311,4 +311,22 @@ test_expect_success \
test_must_fail git cat-file blob $blob_2 > /dev/null &&
test_must_fail git cat-file blob $blob_3 > /dev/null'
+test_expect_success \
+ 'apply good minimal delta' \
+ 'printf "\x00\x01\x01X" > minimal_delta &&
+ test-tool delta -p /dev/null minimal_delta /dev/null
+ '
+
+test_expect_success \
+ 'apply truncated delta' \
+ 'printf "\x00\x02\x02X" > truncated_delta &&
+ test_must_fail test-tool delta -p /dev/null truncated_delta /dev/null
+ '
+
+test_expect_success \
+ 'apply delta with trailing garbage command' \
+ 'printf "\x00\x01\x01X\x01" > tail_garbage_delta &&
+ test_must_fail test-tool delta -p /dev/null tail_garbage_delta /dev/null
+ '
+
test_done
--
2.19.0.rc0.228.g281dcd1b4d0-goog
next prev parent reply other threads:[~2018-08-29 20:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 20:58 [PATCH 1/3] patch-delta: fix oob read Jann Horn
2018-08-29 20:58 ` [PATCH 2/3] t/helper/test-delta: segfault on OOB access Jann Horn
2018-08-29 21:34 ` Jeff King
2018-08-29 21:40 ` Jann Horn
2018-08-29 21:46 ` Jeff King
2018-08-29 21:48 ` Jeff King
2018-08-29 20:58 ` Jann Horn [this message]
2018-08-29 22:03 ` [PATCH 3/3] t5303: add tests for corrupted deltas Jeff King
2018-08-29 22:30 ` Jeff King
2018-08-29 21:20 ` [PATCH 1/3] patch-delta: fix oob read Jeff King
2018-08-29 22:18 ` Jeff King
2018-08-30 7:05 ` [PATCH 0/5] handle corruption in patch-delta Jeff King
2018-08-30 7:07 ` [PATCH 1/5] test-delta: read input into a heap buffer Jeff King
2018-08-30 7:09 ` [PATCH 2/5] t5303: test some corrupt deltas Jeff King
2018-08-30 17:38 ` Junio C Hamano
2018-08-30 18:42 ` Jeff King
2018-08-30 18:44 ` Jeff King
2018-08-30 18:50 ` Junio C Hamano
2018-08-30 19:13 ` Jeff King
2018-08-31 9:58 ` Johannes Schindelin
2018-08-31 15:33 ` Junio C Hamano
2018-08-31 19:47 ` Jeff King
2018-08-31 21:39 ` Junio C Hamano
2018-08-31 21:14 ` Johannes Schindelin
2018-08-31 21:41 ` Jeff King
2018-08-31 21:55 ` Junio C Hamano
2018-08-30 7:09 ` [PATCH 3/5] patch-delta: fix oob read Jeff King
2018-08-30 7:10 ` [PATCH 4/5] patch-delta: consistently report corruption Jeff King
2018-08-30 7:12 ` [PATCH 5/5] patch-delta: handle truncated copy parameters Jeff King
2018-08-30 13:25 ` [PATCH 0/5] handle corruption in patch-delta Jann Horn
2018-08-30 15:23 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829205857.77340-3-jannh@google.com \
--to=jannh@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=nico@cam.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).