From: smaudet@sebastianaudet.com
To: git@vger.kernel.org
Subject: [Bug] Pathspec matching breaks the add command
Date: Mon, 17 Sep 2018 01:52:59 +0000 [thread overview]
Message-ID: <20180917015259.GA26339@sebastianaudet.com> (raw)
The following:
git add -u :\(glob,attr:-someAttr\):src/**
Produces an error that, according to the source code, should never be visible to the user. This attribute/pathspec *should* be supported according to the documentation provided by git:
fatal: BUG:builtin/add.c:498: unsupported magic 40
It looks like the documentation claims more features than the source code supports, perhaps incorrectly because I think you shouldn't be restricted to a set of attributes, and the source code
doesn't properly do its job anyways and never handles this scenario.
This should be fixed, if I have any time I'll look into what it would take to submit a patch, but I don't have the time for this right now.
next reply other threads:[~2018-09-17 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 1:52 smaudet [this message]
2018-09-17 16:28 ` [Bug] Pathspec matching breaks the add command Duy Nguyen
2018-09-17 17:51 ` Brandon Williams's E-Mail bouncing Ævar Arnfjörð Bjarmason
2018-09-17 18:04 ` Stefan Beller
2018-09-18 17:31 ` [PATCH] add: do not accept pathspec magic 'attr' Nguyễn Thái Ngọc Duy
2018-09-19 19:19 ` Junio C Hamano
2018-09-20 21:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917015259.GA26339@sebastianaudet.com \
--to=smaudet@sebastianaudet.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).