From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 902DA1F404 for ; Mon, 17 Sep 2018 01:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbeIQHSC (ORCPT ); Mon, 17 Sep 2018 03:18:02 -0400 Received: from sebastianaudet.com ([45.56.118.10]:37944 "EHLO localhost" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725996AbeIQHSC (ORCPT ); Mon, 17 Sep 2018 03:18:02 -0400 Received: from smaudet by localhost with local (Exim 4.89) (envelope-from ) id 1g1iii-0006vj-0B for git@vger.kernel.org; Mon, 17 Sep 2018 01:53:00 +0000 Date: Mon, 17 Sep 2018 01:52:59 +0000 From: smaudet@sebastianaudet.com To: git@vger.kernel.org Subject: [Bug] Pathspec matching breaks the add command Message-ID: <20180917015259.GA26339@sebastianaudet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The following: git add -u :\(glob,attr:-someAttr\):src/** Produces an error that, according to the source code, should never be visible to the user. This attribute/pathspec *should* be supported according to the documentation provided by git: fatal: BUG:builtin/add.c:498: unsupported magic 40 It looks like the documentation claims more features than the source code supports, perhaps incorrectly because I think you shouldn't be restricted to a set of attributes, and the source code doesn't properly do its job anyways and never handles this scenario. This should be fixed, if I have any time I'll look into what it would take to submit a patch, but I don't have the time for this right now.