From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] reflog expire: add progress output
Date: Wed, 19 Sep 2018 15:01:10 -0400 [thread overview]
Message-ID: <20180919190110.GA14552@sigill.intra.peff.net> (raw)
In-Reply-To: <87tvmljtaz.fsf@evledraar.gmail.com>
On Wed, Sep 19, 2018 at 07:22:44PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > Do we have --quiet option or something that needs to completely
> > suppress this progress thing?
>
> Yes. I also see my commit graph process patches sitting in "next" broke
> the "git gc --quiet" mode, and I'll need to submit something on top
> (which'll be easy), and submit a v2 on this (pending further
> comments...).
>
> Is there a better way to test that (fake up the file descriptor check)
> in the tests other than adding getenv("GIT_TEST...") to the progress.c
> logic?
The progress code doesn't do the isatty() check at all. The caller has
to do it (and ideally would respect --progress/--no-progress to
override, along with having --quiet imply --no-progress if such an
option exists).
Once you have all that, then you can test --progress explicitly. If you
want to check the isatty() handling, you can use test_terminal().
-Peff
next prev parent reply other threads:[~2018-09-19 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:10 [PATCH] reflog expire: add progress output Ævar Arnfjörð Bjarmason
2018-09-19 16:26 ` Duy Nguyen
2018-09-19 17:22 ` Ævar Arnfjörð Bjarmason
2018-09-19 19:01 ` Jeff King [this message]
2018-09-19 20:16 ` Ævar Arnfjörð Bjarmason
2018-09-20 16:19 ` Duy Nguyen
2018-09-21 2:17 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919190110.GA14552@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).