From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] Add an EditorConfig file
Date: Thu, 20 Sep 2018 22:35:04 -0400 [thread overview]
Message-ID: <20180921023503.GA29606@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cTQuwMDMpHe4inO61=Mq2+q1OdGsEG_hpii+dNmjXHZLg@mail.gmail.com>
On Thu, Sep 20, 2018 at 10:26:47PM -0400, Eric Sunshine wrote:
> On Wed, Sep 19, 2018 at 8:00 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> > (I am having trouble getting make style to work, though, because it
> > seems to invoke clang-format as a git subcommand, and I don't think that
> > works. I may send a patch.)
>
> You're probably missing this piece:
> https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format
I've been confused by this, too. In Debian they ship it with the version
number. E.g., /usr/bin/git-clang-format-7, which is a symlink to
/usr/lib/llvm-7/bin/git-clang-format.
We might want a Makefile variable to let you override this path (I think
I just ended up putting another symlink in ~/local/bin).
-Peff
next prev parent reply other threads:[~2018-09-21 2:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 23:03 [PATCH] Add an EditorConfig file brian m. carlson
2018-09-17 23:18 ` Taylor Blau
2018-09-20 0:05 ` brian m. carlson
2018-09-19 3:00 ` Junio C Hamano
2018-09-20 0:00 ` brian m. carlson
2018-09-20 14:08 ` Junio C Hamano
2018-09-21 22:50 ` brian m. carlson
2018-09-24 20:05 ` Junio C Hamano
2018-09-27 22:33 ` brian m. carlson
2018-09-21 2:26 ` Eric Sunshine
2018-09-21 2:35 ` Jeff King [this message]
2018-09-21 22:19 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921023503.GA29606@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).