From: frederik@ofb.net
To: Junio C Hamano <gitster@pobox.com>
Cc: Duy Nguyen <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples
Date: Fri, 21 Sep 2018 09:48:16 -0700 [thread overview]
Message-ID: <20180921164802.GB11082@ofb.net> (raw)
In-Reply-To: <xmqqsh22x14v.fsf@gitster-ct.c.googlers.com>
Thank you Junio, maybe I will have another chance to get practice
sending a v2 patch.
On Fri, Sep 21, 2018 at 09:32:00AM -0700, Junio C Hamano wrote:
> frederik@ofb.net writes:
>
> > On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote:
> >> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:
> >> > > @@ -23,7 +26,7 @@ OPTIONS
> >> > >
> >> > > --mode=<mode>::
> >> > > Specify layout mode. See configuration variable column.ui for option
> >> > > - syntax.
> >> > > + syntax (in git-config(1)).
> >>
> >> I think we usually link to other commands with "linkgit", like
> >> linkgit:git-config[1]
> >>
> >> Other than that, the rest looks good.
> >
> > Thank you, then do I edit the patch and resubmit as PATCH v2 with the
> > message ID and all that?
> >
> > Frederick
>
> If this is the only change in the whole 3 patches, then I can just
> squash in the following to save one round-trip.
>
> Documentation/git-column.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-column.txt b/Documentation/git-column.txt
> index 5bbb51068e..763afabb6d 100644
> --- a/Documentation/git-column.txt
> +++ b/Documentation/git-column.txt
> @@ -26,7 +26,7 @@ OPTIONS
>
> --mode=<mode>::
> Specify layout mode. See configuration variable column.ui for option
> - syntax (in git-config(1)).
> + syntax in linkgit:git-config[1].
>
> --raw-mode=<n>::
> Same as --mode but take mode encoded as a number. This is mainly used
>
next prev parent reply other threads:[~2018-09-21 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 20:12 [PATCH 0/3] some documentation changes from the beginning of the alphabet Frederick Eaton
2018-09-19 20:12 ` [PATCH 1/3] git-archimport.1: specify what kind of Arch we're talking about Frederick Eaton
2018-09-19 22:59 ` Junio C Hamano
2018-09-19 23:13 ` frederik
2018-09-19 20:12 ` [PATCH 2/3] git-column.1: clarify initial description, provide examples Frederick Eaton
2018-09-19 22:59 ` Junio C Hamano
2018-09-20 16:23 ` Duy Nguyen
2018-09-20 17:47 ` frederik
2018-09-21 5:32 ` Eric Sunshine
2018-09-21 16:32 ` Junio C Hamano
2018-09-21 16:48 ` frederik [this message]
2018-09-19 20:12 ` [PATCH 3/3] git-describe.1: clarify that "human readable" is also git-readable Frederick Eaton
2018-09-19 22:49 ` [PATCH 0/3] some documentation changes from the beginning of the alphabet Junio C Hamano
2018-09-21 5:18 ` Eric Sunshine
2018-09-21 5:45 ` frederik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921164802.GB11082@ofb.net \
--to=frederik@ofb.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).