From: Jeff King <peff@peff.net>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] coccicheck: process every source file at once
Date: Tue, 2 Oct 2018 17:08:21 -0400 [thread overview]
Message-ID: <20181002210821.GA27904@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+P7+xqxov6-+t6ixuVxUvi=yfjDuxsa8poGL0TrUrWoj3NUNA@mail.gmail.com>
On Tue, Oct 02, 2018 at 01:58:10PM -0700, Jacob Keller wrote:
> On Tue, Oct 2, 2018 at 1:31 PM Jeff King <peff@peff.net> wrote:
> > Actually, I guess we do not need to save $? at all, since we have only a
> > single process to care about. So even simpler:
> >
> > spatch ... 2>$@+ 2>$@.log ||
> > {
> > cat $@.log
> > exit 1
> > }
> > # if we get here, we were successful
> > mv $@+ $@ ;# etc
> >
> > would work. That's missing all the Makefile=required backslashes and
> > semicolons, of course. ;)
> >
>
> I opted to drop to just save the return, immediately after calling.
> It's a bit less code change, and I think the result is as clear as the
> above would be. This way we do drop the subshell, not that it matters
> much in the end...
Yeah. To be clear, I'm fine with any of the versions discussed in this
thread. Thanks for working on this!
-Peff
next prev parent reply other threads:[~2018-10-02 21:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 19:16 [PATCH] coccicheck: process every source file at once Jacob Keller
2018-10-02 19:55 ` Jeff King
2018-10-02 20:00 ` Jacob Keller
2018-10-02 20:31 ` Jeff King
2018-10-02 20:58 ` Jacob Keller
2018-10-02 21:08 ` Jeff King [this message]
2018-10-03 10:16 ` SZEDER Gábor
2018-10-03 15:05 ` SZEDER Gábor
2018-10-03 15:52 ` Jacob Keller
2018-10-03 17:54 ` Stefan Beller
2018-10-03 15:51 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002210821.GA27904@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).