wrong output on fail

wrong output on fail

[Paul Wratt]

--------------
...
Total 21 (delta 8), reused 0 (delta 0)
error: RPC failed; result=56, HTTP code = 0
fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly
Everything up-to-date
--------------

I am getting the above from "git push".

I am having intermittent HTTPS connection failures with my ISP
(Vodafone NZ, mobile), although HTTP works fine. It may even be a
peering issue.

The failures above are accounted for, but that last line is definitely wrong

Cheers
Paul

Re: wrong output on fail

[Jeff King]

On Sat, Sep 29, 2018 at 03:30:21PM +1200, Paul Wratt wrote:

> --------------
> ...
> Total 21 (delta 8), reused 0 (delta 0)
> error: RPC failed; result=56, HTTP code = 0
> fatal: The remote end hung up unexpectedly
> fatal: The remote end hung up unexpectedly
> Everything up-to-date
> --------------
> 
> I am getting the above from "git push".
> 
> I am having intermittent HTTPS connection failures with my ISP
> (Vodafone NZ, mobile), although HTTP works fine. It may even be a
> peering issue.
> 
> The failures above are accounted for, but that last line is definitely wrong

Yes, that's unfortunate. Usually we'd complain if the connection drops,
but I wonder if this has to do with the extra trip through
git-remote-https. I.e., that program sees the failure and dies, but we
don't manage to pass back the error code to the main git-push process.

It sounds like this is repeatable? If so, can you try with GIT_TRACE=1
and GIT_TRANSPORT_HELPER_DEBUG=1 set in the environment?

-Peff