bug when combined with etckeeper

bug when combined with etckeeper

[Naja Melan]

I am running:

Linux  4.18.12-arch1-1-ARCH #1 SMP PREEMPT Thu Oct 4 01:01:27 UTC 2018 x86_64 GNU/Linux

git version 2.19.1

etckeeper Version: 1.18.8


I ran into a strange bug. In the following script the commit at the end will fail with: 

> The following paths are ignored by one of your .gitignore files:
> .etckeeper
> Use -f if you really want to add them.

Note that there is no .gitignore file and no `.etckeeper` file in the repository, there is nothing in .git/exclude. There is no `core.excludesFile`, not locally, global, nor system. There are no userwide or systemwide ignore files. In fact there is not a single text file on my system which matches the regex '^\.etckeeper'. 

Also `git check-ignore .etckeeper` returns exit status 1. Thus I conclude that something isn't right. I don't know where the exclude rule comes from...

It works as expected if the `-a` option is not used on `git commit`.

I have not found any hints in the scripts from the etckeeper package that might explain this.

#------------------------------------------------
#! /usr/bin/bash

rm -rf gitignorebug

mkdir gitignorebug

cd gitignorebug

git init

git config --local user.name  "git bug"
git config --local user.email "git@bug.com"

touch file

git add file

git commit -am"add file"
#---------------------------------------------------

Thank you for looking into it.

Re: bug when combined with etckeeper

[Jeff King]

On Wed, Oct 10, 2018 at 09:33:00AM +0000, Naja Melan wrote:

> I ran into a strange bug. In the following script the commit at the end will fail with: 
> 
> > The following paths are ignored by one of your .gitignore files:
> > .etckeeper
> > Use -f if you really want to add them.
> 
> Note that there is no .gitignore file and no `.etckeeper` file in the
> repository, there is nothing in .git/exclude.

That's weird. Do you have any git-related environment variables set? Or
anything in your config that might be pointing git to an alternate
repository or working tree?

Try:

  env | grep GIT

and:

  git config --list --show-origin

-Peff

Re: bug when combined with etckeeper

[Joey Hess]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

/etc/.git/hooks/pre-commit is installed by etckeeper and runs
etckeeper pre-commit, which deals with /etc/.etckeeper, including
running "git add .etckeeper". Why that file would match a gitignore
seems much less important than why git would run that hook in an
entirely different git repository.

       core.hooksPath
           By default Git will look for your hooks in the $GIT_DIR/hooks
           directory. Set this to different path, e.g.  /etc/git/hooks, and Git
           will try to find your hooks in that directory, e.g.
           /etc/git/hooks/pre-receive instead of in $GIT_DIR/hooks/pre-receive.

Hmm, the example "/etc/git/hooks" there is very similar to the
"/etc/.git/hooks" used by etckeeper. So my guess is you have
core.hooksPath set globally.

-- 
see shy jo

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: bug when combined with etckeeper

[Naja Melan]

Ok,

my bad. I had a global pre-commit hook which had a lingering etckeeper command for another repository.

Not quite sure why it only runs when commit has the '-a' option...

Thanks for pointing to the hooks possibility.

Naja Melan