From: Jeff King <peff@peff.net>
To: Tao Qingyun <taoqy@ls-a.me>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2] branch: trivial style fix
Date: Tue, 16 Oct 2018 11:33:22 -0400 [thread overview]
Message-ID: <20181016153322.GC29432@sigill.intra.peff.net> (raw)
In-Reply-To: <20181016141919.2268-1-taoqy@ls-a.me>
On Tue, Oct 16, 2018 at 10:19:20PM +0800, Tao Qingyun wrote:
> Signed-off-by: Tao Qingyun <taoqy@ls-a.me>
> ---
> builtin/branch.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/builtin/branch.c b/builtin/branch.c
> index c396c41533..0aa3dac27b 100644
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -716,8 +716,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> print_columns(&output, colopts, NULL);
> string_list_clear(&output, 0);
> return 0;
> - }
> - else if (edit_description) {
> + } else if (edit_description) {
> const char *branch_name;
> struct strbuf branch_ref = STRBUF_INIT;
Yep, this looks reasonable. Normally I would complain about an empty
commit message, but there is really not much else to say. ;)
-Peff
prev parent reply other threads:[~2018-10-16 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 9:52 [PATCH] branch: trivial style fix Tao Qingyun
2018-10-05 16:21 ` Jeff King
2018-10-05 16:47 ` Junio C Hamano
[not found] ` <87bm87x5z2.fsf@ls-a.me>
2018-10-15 19:35 ` Jeff King
2018-10-16 14:14 ` Tao Qingyun
2018-10-16 14:27 ` Ævar Arnfjörð Bjarmason
2018-10-16 15:32 ` Jeff King
2018-10-16 14:19 ` [PATCH v2] " Tao Qingyun
2018-10-16 15:33 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016153322.GC29432@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=taoqy@ls-a.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).