From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] config.mak.dev: enable -Wunused-function
Date: Thu, 18 Oct 2018 03:08:32 -0400 [thread overview]
Message-ID: <20181018070831.GA29542@sigill.intra.peff.net> (raw)
In-Reply-To: <20181018070522.GA29499@sigill.intra.peff.net>
On Thu, Oct 18, 2018 at 03:05:22AM -0400, Jeff King wrote:
> diff --git a/config.mak.dev b/config.mak.dev
> index 92d268137f..bbeeff44fe 100644
> --- a/config.mak.dev
> +++ b/config.mak.dev
> @@ -34,7 +34,6 @@ ifeq ($(filter extra-all,$(DEVOPTS)),)
> CFLAGS += -Wno-empty-body
> CFLAGS += -Wno-missing-field-initializers
> CFLAGS += -Wno-sign-compare
> -CFLAGS += -Wno-unused-function
> CFLAGS += -Wno-unused-parameter
By the way, I wondered how close we were to being able to use
-Wunused-parameter. The answer is "not very".
However, I've been digging into the results, and it does find a number
of bugs. I'm 168 (rough) patches deep right now, and I have it compiling
cleanly. Most of those are just annotations, but I'll start posting
fixes as I organize and clean them up.
-Peff
next prev parent reply other threads:[~2018-10-18 7:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 7:05 [PATCH] config.mak.dev: enable -Wunused-function Jeff King
2018-10-18 7:08 ` Jeff King [this message]
2018-10-18 15:48 ` Duy Nguyen
2018-10-18 17:09 ` Jeff King
2018-10-18 18:05 ` [PATCH/RFC] thread-utils: better wrapper to avoid #ifdef NO_PTHREADS Nguyễn Thái Ngọc Duy
2018-10-23 20:28 ` Jeff King
2018-10-24 2:58 ` Junio C Hamano
2018-10-26 14:09 ` Ben Peart
2018-10-27 7:12 ` can we deprecate NO_PTHREADS?, was: " Jeff King
2018-10-27 7:26 ` [PATCH/RFC] thread-utils: " Duy Nguyen
2018-10-27 8:17 ` Jeff King
2018-10-18 17:01 ` [PATCH] config.mak.dev: enable -Wunused-function Ramsay Jones
2018-10-19 1:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018070831.GA29542@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).