From: Jeff King <peff@peff.net>
To: Ben Peart <peartben@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Ben Peart" <benpeart@microsoft.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v1] load_cache_entries_threaded: remove unused src_offset parameter
Date: Tue, 23 Oct 2018 16:07:30 -0400 [thread overview]
Message-ID: <20181023200730.GB15214@sigill.intra.peff.net> (raw)
In-Reply-To: <7a359876-7d36-5d01-5f47-76ef316b6386@gmail.com>
On Tue, Oct 23, 2018 at 03:13:06PM -0400, Ben Peart wrote:
> At one point I also had the additional #ifndef NO_PTHREADS lines but it was
> starting to get messy with the threaded vs non-threaded code paths so I
> removed them. I'm fine with which ever people find more readable.
>
> It does make me wonder if there are still platforms taking new build of git
> that don't support threads. Do we still need to write/test/debug/read
> through the single threaded code paths?
I think the classic offenders here were old Unix systems like AIX, etc.
I've no idea what the current state is on those platforms. I would love
it if we could drop NO_PTHREADS. There's a lot of gnarly code there, and
I strongly suspect a lot of bugs lurk in the non-threaded halves (e.g.,
especially around bits like "struct async" which is "maybe a thread, and
maybe a fork" depending on your system, which introduces all kinds of
subtle process-state dependencies).
But I'm not really sure how to find out aside from adding a deprecation
warning and seeing if anybody screams.
See also this RFC from Duy, which might at least make the code itself a
little easier to follow:
https://public-inbox.org/git/20181018180522.17642-1-pclouds@gmail.com/
-Peff
prev parent reply other threads:[~2018-10-23 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 15:05 [PATCH v1] load_cache_entries_threaded: remove unused src_offset parameter Ben Peart
2018-10-22 20:17 ` Jeff King
2018-10-22 23:05 ` Junio C Hamano
2018-10-23 19:13 ` Ben Peart
2018-10-23 20:07 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023200730.GB15214@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).