From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
lucas.de.marchi@gmail.com
Subject: Re: [PATCH] range-diff: allow to diff files regardless submodule
Date: Tue, 23 Oct 2018 19:43:09 -0700 [thread overview]
Message-ID: <20181024024309.GA22379@ldmartin-desk.jf.intel.com> (raw)
In-Reply-To: <xmqqh8hcqeho.fsf@gitster-ct.c.googlers.com>
On Wed, Oct 24, 2018 at 11:12:51AM +0900, Junio C Hamano wrote:
> Lucas De Marchi <lucas.demarchi@intel.com> writes:
>
> >> Yes, I agree on both counts (i.e. it was totally unclear what
> >> problem is being solved and what the root cause of the problem is,
> >> and we would want a new test to protect this "fix" from getting
> >> broken in the future.
> >
> > have you seen I sent a v2 with proper test?
>
> No, otherwise I wouln't have said it needs tests, and no, because I
> haven't seen the v2, I do not know if it came with proper test or
> other issues pointed out and fixes suggested in the review round
> were addressed in v2. Sorry.
Your reply arrived just a little after I sent the v2, so I thought it
was just the race and you would end up seeing the unread email in the
same thread. Sorry for not including the msg id:
20181011081750.24240-1-lucas.demarchi@intel.com
thanks
Lucas De Marchi
>
> When you ask such a question, please accompany it with "this is the
> message-id" to avoid the receiver of the question locating a wrong
> version of your patch from the archive.
>
> Thanks.
next prev parent reply other threads:[~2018-10-24 3:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 15:09 [PATCH] range-diff: allow to diff files regardless submodule Lucas De Marchi
2018-10-11 0:02 ` brian m. carlson
2018-10-11 7:50 ` Lucas De Marchi
2018-10-12 9:24 ` Johannes Schindelin
2018-10-12 23:17 ` brian m. carlson
2018-10-11 7:42 ` Ævar Arnfjörð Bjarmason
2018-10-11 8:14 ` Lucas De Marchi
2018-10-11 8:17 ` [PATCH v2] " Lucas De Marchi
2018-10-12 9:26 ` Johannes Schindelin
2018-10-11 8:25 ` [PATCH] " Junio C Hamano
2018-10-23 14:07 ` Lucas De Marchi
2018-10-24 2:12 ` Junio C Hamano
2018-10-24 2:43 ` Lucas De Marchi [this message]
2018-10-24 5:12 ` Junio C Hamano
2018-10-24 5:18 ` Junio C Hamano
2018-10-24 17:19 ` Lucas De Marchi
2018-10-24 19:46 ` [PATCH v3] range-diff: allow to diff files regardless of submodule config Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024024309.GA22379@ldmartin-desk.jf.intel.com \
--to=lucas.demarchi@intel.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=lucas.de.marchi@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).