From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: alban.gruin@gmail.com, "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH] sequencer: cleanup for gcc 8.2.1 warning
Date: Wed, 24 Oct 2018 17:14:06 -0700 [thread overview]
Message-ID: <20181025001406.6729-1-carenas@gmail.com> (raw)
sequencer.c: In function ‘write_basic_state’:
sequencer.c:2392:37: warning: zero-length gnu_printf format string [-Wformat-zero-length]
write_file(rebase_path_verbose(), "");
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
sequencer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sequencer.c b/sequencer.c
index 8dd6db5a01..358e83bf6b 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -2335,7 +2335,7 @@ int write_basic_state(struct replay_opts *opts, const char *head_name,
write_file(rebase_path_quiet(), "\n");
if (opts->verbose)
- write_file(rebase_path_verbose(), "");
+ write_file(rebase_path_verbose(), "\n");
if (opts->strategy)
write_file(rebase_path_strategy(), "%s\n", opts->strategy);
if (opts->xopts_nr > 0)
--
2.19.1
next reply other threads:[~2018-10-25 0:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 0:14 Carlo Marcelo Arenas Belón [this message]
2018-10-25 5:36 ` [PATCH] sequencer: cleanup for gcc 8.2.1 warning Junio C Hamano
2018-10-25 6:22 ` Junio C Hamano
2018-10-25 7:10 ` Carlo Arenas
2018-10-25 8:08 ` Junio C Hamano
2018-10-25 9:15 ` Carlo Arenas
2018-10-25 9:38 ` [PATCH v2] sequencer: cleanup for gcc warning in non developer mode Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025001406.6729-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).