git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: pclouds@gmail.com, peff@peff.net, chriscool@tuxfamily.org,
	l.s.r@web.de, ramsay@ramsayjones.plus.com,
	"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH v3 0/3] delta-islands: avoid unused function messages
Date: Thu, 25 Oct 2018 04:04:24 -0700	[thread overview]
Message-ID: <20181025110427.13655-1-carenas@gmail.com> (raw)

the macro generated code from delta-islands (using khash) triggers
some unused function warnings in macOS, OpenBSD and some linux with a
newer version of clang because of its use of static functions.

Changes from v2:
* Relay in the C code including git-compat-util as suggested by Jeff
* Commit message cleanup
* Make changes hdr-check clean

Changes from v1:
* Use MAYBE_UNUSED for all cases as suggested by Duy

Carlo Marcelo Arenas Belón (3):
  commit-slab: move MAYBE_UNUSED into git-compat-util
  khash: silence -Wunused-function in delta-islands from khash
  commit-slab: missing definitions and forward declarations (hdr-check)

 commit-slab-impl.h | 4 ++--
 commit-slab.h      | 2 ++
 git-compat-util.h  | 2 ++
 khash.h            | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)

-- 
2.19.1


             reply	other threads:[~2018-10-25 11:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 11:04 Carlo Marcelo Arenas Belón [this message]
2018-10-25 11:04 ` [PATCH v3 1/3] commit-slab: move MAYBE_UNUSED into git-compat-util Carlo Marcelo Arenas Belón
2018-10-25 11:04 ` [PATCH v3 2/3] khash: silence -Wunused-function in delta-islands from khash Carlo Marcelo Arenas Belón
2018-10-25 11:30   ` SZEDER Gábor
2018-10-25 11:04 ` [PATCH v3 3/3] commit-slab: missing definitions and forward declarations (hdr-check) Carlo Marcelo Arenas Belón
2018-10-25 18:54   ` Ramsay Jones
2018-10-25 21:08     ` Ramsay Jones
2018-10-26  3:15       ` Carlo Arenas
2018-10-27  1:45         ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025110427.13655-1-carenas@gmail.com \
    --to=carenas@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).