From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] test-lib: introduce the '-V' short option for '--verbose-log'
Date: Mon, 29 Oct 2018 10:21:08 -0400 [thread overview]
Message-ID: <20181029142108.GD17668@sigill.intra.peff.net> (raw)
In-Reply-To: <20181029121359.7323-1-szeder.dev@gmail.com>
On Mon, Oct 29, 2018 at 01:13:59PM +0100, SZEDER Gábor wrote:
> '--verbose-log' is one of the most useful and thus most frequently
> used test options, but due to its length it's a pain to type on the
> command line.
>
> Let's introduce the corresponding short option '-V' to save some
> keystrokes.
Interesting. I'm not opposed to something like this, but I added
"--verbose-log" specifically for scripted cases, like running an
unattended "prove" that needs to preserve stdout. When running
individual tests, I'd just use "-v" itself, and possibly redirect the
output.
For my curiosity, can you describe your use case a bit more?
> t/README | 1 +
> t/test-lib.sh | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
The patch itself looks good to me.
-Peff
next prev parent reply other threads:[~2018-10-29 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 12:13 [PATCH] test-lib: introduce the '-V' short option for '--verbose-log' SZEDER Gábor
2018-10-29 14:21 ` Jeff King [this message]
2018-10-29 13:53 ` SZEDER Gábor
2018-10-29 15:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029142108.GD17668@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).