From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, anmolmago@gmail.com, briankyho@gmail.com,
david.lu97@outlook.com, shirui.wang@hotmail.com
Subject: Re: [PATCH] completion: use builtin completion for format-patch
Date: Mon, 29 Oct 2018 23:50:36 -0400 [thread overview]
Message-ID: <20181030035036.GA14941@archbookpro.localdomain> (raw)
In-Reply-To: <xmqqbm7c2n0i.fsf@gitster-ct.c.googlers.com>
On Tue, Oct 30, 2018 at 11:20:45AM +0900, Junio C Hamano wrote:
> We saw a similar change proposed and then found out it was not such
> a good idea in:
>
> https://public-inbox.org/git/CACsJy8DUrVJu0HN7kuCeo4iV5aimWbYtr+E-7kenPVDx90DpGw@mail.gmail.com/
>
> It seems that this one loses options like --full-index, --no-prefix,
> etc. compared to the earlier effort?
In _git_send_email, we have the following lines:
__gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
... more options ...
$__git_format_patch_options"
Would it make sense to take the old `__git_format_patch_options` and
just roll them into here, then make `_git_format_patch` use
`__gitcomp_builtin format-patch`? That way, we'd be able to reap the
benefits of using `__gitcomp_builtin` where we can.
next prev parent reply other threads:[~2018-10-30 3:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:57 [PATCH] completion: use builtin completion for format-patch Denton Liu
2018-10-30 2:20 ` Junio C Hamano
2018-10-30 3:50 ` Denton Liu [this message]
2018-10-30 6:38 ` [PATCH v2] " Denton Liu
2018-10-30 7:33 ` Junio C Hamano
2018-10-30 15:29 ` Duy Nguyen
2018-11-01 1:42 ` Junio C Hamano
2018-11-01 15:40 ` Duy Nguyen
2018-11-01 23:52 ` Junio C Hamano
2018-11-03 6:03 ` Duy Nguyen
2018-11-03 7:59 ` Denton Liu
2018-11-03 8:29 ` Duy Nguyen
2018-11-03 10:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030035036.GA14941@archbookpro.localdomain \
--to=liu.denton@gmail.com \
--cc=anmolmago@gmail.com \
--cc=briankyho@gmail.com \
--cc=david.lu97@outlook.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=shirui.wang@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).