From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: ab/* topics (was: Re: What's cooking in git.git (Nov 2018, #01; Thu, 1))
Date: Thu, 1 Nov 2018 14:10:22 +0100 [thread overview]
Message-ID: <20181101131022.GU30222@szeder.dev> (raw)
In-Reply-To: <8736slkqmu.fsf@evledraar.gmail.com>
On Thu, Nov 01, 2018 at 12:02:01PM +0100, Ævar Arnfjörð Bjarmason wrote:
> Could you please pick up
> https://public-inbox.org/git/20181024114725.3927-1-avarab@gmail.com/ ?
> It seems to have fallen between the cracks and addressed the feedback on
> v1, and looks good to me (and nobody's objected so far...).
I didn't object, because in
https://public-inbox.org/git/87muqzllh0.fsf@evledraar.gmail.com/
you asked for "a more general review than just the problem of how
we turn an env variable into a boolean".
However, if you push that patch with 'sh-i18n--helper' as-is, then I
do object now: parsing a boolean in shell is not at all that difficult
to justify this new command.
next prev parent reply other threads:[~2018-11-01 13:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 9:59 What's cooking in git.git (Nov 2018, #01; Thu, 1) Junio C Hamano
2018-11-01 11:02 ` ab/* topics (was: Re: What's cooking in git.git (Nov 2018, #01; Thu, 1)) Ævar Arnfjörð Bjarmason
2018-11-01 13:10 ` SZEDER Gábor [this message]
2018-11-01 13:46 ` Ævar Arnfjörð Bjarmason
2018-11-01 14:30 ` SZEDER Gábor
2018-11-01 13:28 ` ab/* topics Junio C Hamano
2018-11-01 15:32 ` Duy Nguyen
2018-11-01 19:38 ` Ævar Arnfjörð Bjarmason
2018-11-01 16:07 ` master updated? (was Re: What's cooking in git.git (Nov 2018, #01; Thu, 1)) Derrick Stolee
2018-11-02 0:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101131022.GU30222@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).