From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] it's called read_object_file() these days
Date: Fri, 2 Nov 2018 02:24:29 -0400 [thread overview]
Message-ID: <20181102062429.GA29939@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqpnvoovzk.fsf@gitster-ct.c.googlers.com>
On Fri, Nov 02, 2018 at 03:05:03PM +0900, Junio C Hamano wrote:
> Remnant of the old name of the function still remains in comments.
> Update them all.
Yay. What's here looks obviously correct.
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> apply.c | 2 +-
> builtin/gc.c | 2 +-
> fast-import.c | 4 ++--
> notes.c | 2 +-
> object.h | 2 +-
> sha1-file.c | 2 +-
> 6 files changed, 7 insertions(+), 7 deletions(-)
There's another mention in Documentation/technical/api-object-access.txt.
But since the entire API is undocumented, I'm not sure it matters much.
That file has been a placeholder since 2007. Maybe we should just delete
it; its existence does not seem to be guilting anyone into documenting,
and these days we'd prefer to do it in-header anyway.
-Peff
next prev parent reply other threads:[~2018-11-02 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 6:05 [PATCH] it's called read_object_file() these days Junio C Hamano
2018-11-02 6:24 ` Jeff King [this message]
2018-11-02 11:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102062429.GA29939@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).