From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 04/13] pack-objects: mark index-version option as NONEG
Date: Mon, 5 Nov 2018 01:39:38 -0500 [thread overview]
Message-ID: <20181105063938.GD25864@sigill.intra.peff.net> (raw)
In-Reply-To: <20181105063718.GA24877@sigill.intra.peff.net>
Running "git pack-objects --no-index-version" will segfault, since the
callback is not prepared to handle the "unset" flag.
In theory this might be used to counteract an earlier "--index-version",
or override a pack.indexversion config setting. But the semantics aren't
immediately obvious, and it's unlikely anybody wants this. Let's just
disable the broken option for now.
Signed-off-by: Jeff King <peff@peff.net>
---
builtin/pack-objects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index e50c6cd1ff..4eac2f997b 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -3252,7 +3252,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
N_("similar to --all-progress when progress meter is shown")),
{ OPTION_CALLBACK, 0, "index-version", NULL, N_("<version>[,<offset>]"),
N_("write the pack index file in the specified idx format version"),
- 0, option_parse_index_version },
+ PARSE_OPT_NONEG, option_parse_index_version },
OPT_MAGNITUDE(0, "max-pack-size", &pack_size_limit,
N_("maximum size of each output pack file")),
OPT_BOOL(0, "local", &local,
--
2.19.1.1505.g9cd28186cf
next prev parent reply other threads:[~2018-11-05 6:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 6:37 [PATCH 0/13] parseopt fixes from -Wunused-parameters Jeff King
2018-11-05 6:38 ` [PATCH 01/13] apply: mark include/exclude options as NONEG Jeff King
2018-11-05 7:07 ` Junio C Hamano
2018-11-05 6:38 ` [PATCH 02/13] am: handle --no-patch-format option Jeff King
2018-11-05 7:08 ` Junio C Hamano
2018-11-05 6:39 ` [PATCH 03/13] ls-files: mark exclude options as NONEG Jeff King
2018-11-05 6:39 ` Jeff King [this message]
2018-11-05 6:40 ` [PATCH 05/13] cat-file: mark batch options with NONEG Jeff King
2018-11-05 6:40 ` [PATCH 06/13] status: mark --find-renames option " Jeff King
2018-11-05 6:41 ` [PATCH 07/13] format-patch: mark "--no-numbered" " Jeff King
2018-11-05 6:42 ` [PATCH 08/13] show-branch: mark --reflog option as NONEG Jeff King
2018-11-05 6:43 ` [PATCH 09/13] tag: mark "--message" option with NONEG Jeff King
2018-11-05 6:43 ` [PATCH 10/13] cat-file: report an error on multiple --batch options Jeff King
2018-11-05 6:43 ` [PATCH 11/13] apply: return -1 from option callback instead of calling exit(1) Jeff King
2018-11-05 6:44 ` [PATCH 12/13] parse-options: drop OPT_DATE() Jeff King
2018-11-05 18:34 ` [PATCH] parse-options: deprecate OPT_DATE Carlo Marcelo Arenas Belón
2018-11-05 18:49 ` Jeff King
2018-11-05 6:45 ` [PATCH 13/13] assert NOARG/NONEG behavior of parse-options callbacks Jeff King
2018-11-05 16:51 ` [PATCH 0/13] parseopt fixes from -Wunused-parameters Duy Nguyen
2018-11-05 18:49 ` Jeff King
2018-11-05 18:51 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105063938.GD25864@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).