From: Jonathan Nieder <jrnieder@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Design of multiple hash support
Date: Mon, 5 Nov 2018 14:00:42 -0800 [thread overview]
Message-ID: <20181105220042.GA162375@google.com> (raw)
In-Reply-To: <CACsJy8B+WAyjrthKs9nr=kLpx7f8k_Dug4rRdYDoBR+mmLHCuQ@mail.gmail.com>
Hi,
Duy Nguyen wrote:
> On Mon, Nov 5, 2018 at 2:02 AM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
>> There are basically two approaches I can take. The first is to provide
>> each command that needs to learn about this with its own --hash
>> argument. So we'd have:
>>
>> git init --hash=sha256
>> git show-index --hash=sha256 <some-file
>>
>> The other alternative is that we provide a global option to git, which
>> is parsed by all programs, like so:
>>
>> git --hash=sha256 init
>> git --hash=sha256 show-index <some-file
[...]
> I'm leaning towards "git foo --hash=".
Can you say a little more about the semantics of the option? For
commands like "git init", I tend to agree with Duy here, since it
allows each command's manual to describe what the option means in the
context of that command.
For "git show-index", ideally Git should use the object format named
in the idx file.
>> There's also the question of what we want to call the option. The
>> obvious name is --hash, which is intuitive and straightforward.
>> However, the transition plan names the config option
>> extensions.objectFormat,
[...]
> --object-format is less vague than --hash. The downside is it's longer
> (more to type) but I'm counting on git-completion.bash and the guess
> that people rarely need to use this option.
Agreed. --object-format makes more sense to me than --hash, since
it's more precise about what the option affects.
Thanks for looking into this.
Sincerely,
Jonathan
next prev parent reply other threads:[~2018-11-05 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 1:00 Design of multiple hash support brian m. carlson
2018-11-05 2:36 ` Junio C Hamano
2018-11-05 18:03 ` Stefan Beller
2018-11-05 23:54 ` brian m. carlson
2018-11-05 19:03 ` Duy Nguyen
2018-11-05 22:00 ` Jonathan Nieder [this message]
2018-11-06 0:13 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105220042.GA162375@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).