From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "H . Merijn Brand" <h.m.brand@xs4all.nl>,
"Harald Nordgren" <haraldnordgren@gmail.com>,
"Olga Telezhnaia" <olyatelezhnaya@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] ref-filter: don't look for objects when outside of a repository
Date: Thu, 15 Nov 2018 04:43:20 -0500 [thread overview]
Message-ID: <20181115094320.GA18790@sigill.intra.peff.net> (raw)
In-Reply-To: <20181115093844.GA14218@sigill.intra.peff.net>
On Thu, Nov 15, 2018 at 04:38:44AM -0500, Jeff King wrote:
> Is SOURCE_NONE a complete match for what we want?
>
> I see problems in both directions:
>
> - sorting by "objectname" works now, but it's marked with SOURCE_OBJ,
> and would be forbidden with your patch. I'm actually not sure if
> SOURCE_OBJ is accurate; we shouldn't need to access the object to
> show it (and we are probably wasting effort loading the full contents
> for tools like for-each-ref).
>
> However, that's not the full story. For objectname:short, it _does_ call
> find_unique_abbrev(). So we expect to have an object directory.
Oops, I'm apparently bad at reading. It is in fact SOURCE_OTHER, which
makes sense (outside of this whole "--sort outside a repo thing").
But we'd ideally distinguish between "objectname" (which should be OK
outside a repo) and "objectname:short" (which currently segfaults).
-Peff
next prev parent reply other threads:[~2018-11-15 9:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-22 10:42 Coredump on ls-remote + --sort H.Merijn Brand
2018-09-22 12:33 ` Ævar Arnfjörð Bjarmason
2018-09-22 14:11 ` [PATCH] ref-filter: don't look for objects when outside of a repository SZEDER Gábor
2018-09-24 16:15 ` Junio C Hamano
2018-09-24 18:17 ` Jeff King
2018-09-24 21:20 ` SZEDER Gábor
2018-09-24 21:30 ` Jeff King
2018-09-25 20:57 ` Junio C Hamano
2018-11-14 12:27 ` SZEDER Gábor
2018-11-15 9:38 ` Jeff King
2018-11-15 9:43 ` Jeff King [this message]
2018-11-16 5:09 ` Junio C Hamano
2018-11-16 8:56 ` Jeff King
2018-11-16 10:07 ` Junio C Hamano
2018-11-16 13:16 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115094320.GA18790@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=h.m.brand@xs4all.nl \
--cc=haraldnordgren@gmail.com \
--cc=olyatelezhnaya@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).