From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: git@vger.kernel.org
Subject: RFE: git-patch-id should handle patches without leading "diff"
Date: Fri, 7 Dec 2018 13:19:42 -0500 [thread overview]
Message-ID: <20181207181942.GA6411@pure.paranoia.local> (raw)
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Hi, all:
Every now and again I come across a patch sent to LKML without a leading
"diff a/foo b/foo" -- usually produced by quilt. E.g.:
https://lore.kernel.org/lkml/20181125185004.151077005@linutronix.de/
I am guessing quilt does not bother including the leading "diff a/foo
b/foo" because it's redundant with the next two lines, however this
remains a valid patch recognized by git-am.
If you pipe that patch via git-patch-id, it produces nothing, but if I
put in the leading "diff", like so:
diff a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
then it properly returns "fb3ae17451bc619e3d7f0dd647dfba2b9ce8992e".
Can we please teach git-patch-id to work without the leading diff a/foo
b/foo, same as git-am?
Best,
-K
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next reply other threads:[~2018-12-07 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 18:19 Konstantin Ryabitsev [this message]
2018-12-07 19:25 ` RFE: git-patch-id should handle patches without leading "diff" Ævar Arnfjörð Bjarmason
2018-12-07 22:01 ` Jonathan Nieder
2018-12-07 22:23 ` Ævar Arnfjörð Bjarmason
2018-12-07 22:34 ` Jonathan Nieder
2018-12-08 6:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207181942.GA6411@pure.paranoia.local \
--to=konstantin@linuxfoundation.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).