From: Jeff King <peff@peff.net>
To: John Passaro <john.a.passaro@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH] run-command: report exec failure
Date: Thu, 13 Dec 2018 03:10:58 -0500 [thread overview]
Message-ID: <20181213081057.GC12132@sigill.intra.peff.net> (raw)
In-Reply-To: <CAJdN7Khf+Y_jyyG2qoqiMHYPCHHSws15EDftOQni=gFJ7SoMXg@mail.gmail.com>
On Wed, Dec 12, 2018 at 10:27:40AM -0500, John Passaro wrote:
> Thank you for this incredibly quick fix.
>
> I see the fix made it to pu as 6b206be3e5 ("run-command: report exec
> failure" 2018-12-11). For what it's worth, it fixes the issue as far
> as I'm concerned and I'm very glad to see the behavior is covered by
> tests now.
>
> As a procedural question: I'd like to reference this patch in one of
> my own. Can I reference it as I typed it above? Or is there a chance
> of the SHA1 changing before it goes into some sort of a main history?
Commits in "pu" are still subject to change (and indeed, this one was
amended to e5a329a279 to fix the grep issue on Windows).
Once it hits "next" it is generally stable. That hasn't happened yet,
but I think what's there now is likely to get merged as-is (and will
retain that commit id).
-Peff
next prev parent reply other threads:[~2018-12-13 8:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 5:46 [PATCH] run-command: report exec failure Junio C Hamano
2018-12-11 10:23 ` Jeff King
2018-12-11 12:31 ` Johannes Schindelin
2018-12-11 12:50 ` Junio C Hamano
2018-12-12 15:27 ` John Passaro
2018-12-13 8:10 ` Jeff King [this message]
2018-12-12 18:36 ` [PATCH v2] " Junio C Hamano
2018-12-13 8:08 ` Jeff King
2018-12-13 8:17 ` Junio C Hamano
2018-12-13 11:15 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213081057.GC12132@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john.a.passaro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).