From: John Passaro <john.a.passaro@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, alex.crezoff@gmail.com, peff@peff.net,
mgorny@gentoo.org, John Passaro <john.a.passaro@gmail.com>
Subject: [PATCH 2/4] t/t7510-signed-commit.sh: test new placeholders
Date: Thu, 13 Dec 2018 16:22:54 -0500 [thread overview]
Message-ID: <20181213212256.48122-3-john.a.passaro@gmail.com> (raw)
In-Reply-To: <20181213212256.48122-1-john.a.passaro@gmail.com>
Test that %GR output ("Raw" contents of "gpgsig" header) looks like
ASCII-armored GPG signature.
Test %G+ (Y/N for presence/absence of "gpgsig" header) by adding it to
existing format tests for signed commits.
Signed-off-by: John Passaro <john.a.passaro@gmail.com>
---
t/t7510-signed-commit.sh | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
index 86d3f93fa2..aff6b1eb3a 100755
--- a/t/t7510-signed-commit.sh
+++ b/t/t7510-signed-commit.sh
@@ -177,8 +177,9 @@ test_expect_success GPG 'show good signature with custom format' '
C O Mitter <committer@example.com>
73D758744BE721698EC54E8713B6F51ECDDE430D
73D758744BE721698EC54E8713B6F51ECDDE430D
+ Y
EOF
- git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP" sixth-signed >actual &&
+ git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP%n%G+" sixth-signed >actual &&
test_cmp expect actual
'
@@ -189,8 +190,9 @@ test_expect_success GPG 'show bad signature with custom format' '
C O Mitter <committer@example.com>
+ Y
EOF
- git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP" $(cat forged1.commit) >actual &&
+ git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP%n%G+" $(cat forged1.commit) >actual &&
test_cmp expect actual
'
@@ -201,8 +203,9 @@ test_expect_success GPG 'show untrusted signature with custom format' '
Eris Discordia <discord@example.net>
F8364A59E07FFE9F4D63005A65A0EEA02E30CAD7
D4BE22311AD3131E5EDA29A461092E85B7227189
+ Y
EOF
- git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP" eighth-signed-alt >actual &&
+ git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP%n%G+" eighth-signed-alt >actual &&
test_cmp expect actual
'
@@ -213,8 +216,9 @@ test_expect_success GPG 'show unknown signature with custom format' '
+ Y
EOF
- GNUPGHOME="$GNUPGHOME_NOT_USED" git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP" eighth-signed-alt >actual &&
+ GNUPGHOME="$GNUPGHOME_NOT_USED" git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP%n%G+" eighth-signed-alt >actual &&
test_cmp expect actual
'
@@ -225,11 +229,27 @@ test_expect_success GPG 'show lack of signature with custom format' '
+ N
EOF
- git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP" seventh-unsigned >actual &&
+ git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP%n%G+" seventh-unsigned >actual &&
test_cmp expect actual
'
+test_expect_success GPG 'show lack of raw signature with custom format' '
+ git log -1 --format=format:"%GR" seventh-unsigned > actual &&
+ test_must_be_empty actual
+'
+
+test_expect_success GPG 'show raw signature with custom format' '
+ git log -1 --format=format:"%GR" sixth-signed >output &&
+ cat output &&
+ head -n1 output | grep -q "^---*BEGIN PGP SIGNATURE---*$" &&
+ sed 1d output | grep -q "^$" &&
+ sed "1,/^$/d" output | grep -q "^[a-zA-Z0-9+/][a-zA-Z0-9+/=]*$" &&
+ tail -n2 output | head -n1 | grep -q "^=[a-zA-Z0-9+/][a-zA-Z0-9+/=]*$" &&
+ tail -n1 output | grep -q "^---*END PGP SIGNATURE---*$"
+'
+
test_expect_success GPG 'log.showsignature behaves like --show-signature' '
test_config log.showsignature true &&
git show initial >actual &&
--
2.19.1
next prev parent reply other threads:[~2018-12-13 21:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 21:22 [PATCH 0/4] Expose gpgsig in pretty-print John Passaro
2018-12-13 21:22 ` [PATCH 1/4] pretty: expose raw commit signature John Passaro
2018-12-13 21:22 ` John Passaro [this message]
2018-12-13 21:22 ` [PATCH 3/4] doc, tests: pretty behavior when gpg missing John Passaro
2018-12-13 21:22 ` [PATCH 4/4] docs/pretty-formats: add explanation + copy edits John Passaro
2018-12-14 4:11 ` [PATCH 0/4] Expose gpgsig in pretty-print Michał Górny
2018-12-14 16:07 ` John Passaro
2018-12-14 16:48 ` Michał Górny
2018-12-14 23:10 ` John Passaro
2018-12-14 23:13 ` John Passaro
2018-12-17 20:24 ` Jeff King
2018-12-19 5:59 ` John Passaro
2018-12-21 13:52 ` Michał Górny
2018-12-15 0:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213212256.48122-3-john.a.passaro@gmail.com \
--to=john.a.passaro@gmail.com \
--cc=alex.crezoff@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mgorny@gentoo.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).