Git development
 help / color / mirror / Atom feed
From: Masaya Suzuki <masayasuzuki@google.com>
To: git@vger.kernel.org
Cc: Masaya Suzuki <masayasuzuki@google.com>
Subject: [PATCH] Specify -Wformat along with -Wformat-security
Date: Wed, 26 Dec 2018 22:58:55 -0800	[thread overview]
Message-ID: <20181227065855.68632-1-masayasuzuki@google.com> (raw)

Without -Wformat, -Wformat-security won't work.

> cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]

Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
---
 config.mak.dev | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config.mak.dev b/config.mak.dev
index bbeeff44f..aae9db67d 100644
--- a/config.mak.dev
+++ b/config.mak.dev
@@ -7,6 +7,7 @@ CFLAGS += -pedantic
 CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
 endif
 CFLAGS += -Wdeclaration-after-statement
+CFLAGS += -Wformat
 CFLAGS += -Wformat-security
 CFLAGS += -Wno-format-zero-length
 CFLAGS += -Wold-style-definition
-- 
2.20.1.415.g653613c723-goog


             reply	other threads:[~2018-12-27  6:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-27  6:58 Masaya Suzuki [this message]
2018-12-27 18:35 ` [PATCH] Specify -Wformat along with -Wformat-security Duy Nguyen
2018-12-27 18:46   ` Masaya Suzuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181227065855.68632-1-masayasuzuki@google.com \
    --to=masayasuzuki@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox