From: Joey Hess <id@joeyh.name>
To: Jeff King <peff@peff.net>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git <git@vger.kernel.org>
Subject: Re: git status OOM on mmap of large file
Date: Thu, 24 Jan 2019 13:05:44 -0400 [thread overview]
Message-ID: <20190124170544.GB29200@kitenet.net> (raw)
In-Reply-To: <20190124121427.GB4949@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
Jeff King wrote:
> I didn't experiment with the smudge side, but I think it uses the same
> apply_filter() code. Which means that yes, it would try to store the
> 11GB in memory before writing it out. And I agree writing it out to a
> file and moving it directly into place is the sanest option there. If
> that doesn't work, spooling to a tempfile and then streaming it into
> place would also work.
I have seen that buffering on the smudge side, yes. In git-annex
I happen to use the smudge filter in an unusual way that avoids
that being a problem but I think it would affect git-lfs.
--
see shy jo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-24 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 22:07 git status OOM on mmap of large file Joey Hess
2019-01-24 0:39 ` brian m. carlson
2019-01-24 12:14 ` Jeff King
2019-01-24 17:05 ` Joey Hess [this message]
2019-01-24 12:10 ` Jeff King
2019-01-24 12:54 ` Duy Nguyen
2019-01-24 18:38 ` Joey Hess
2019-01-24 19:18 ` Jeff King
2019-01-24 19:28 ` Jeff King
2019-01-24 20:36 ` [PATCH] avoid unncessary malloc of whole file size Joey Hess
2019-01-24 21:12 ` Junio C Hamano
2019-01-24 21:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124170544.GB29200@kitenet.net \
--to=id@joeyh.name \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).