git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Sebastian Staudt <koraktor@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Setup working tree in describe
Date: Sat, 26 Jan 2019 09:28:54 -0500	[thread overview]
Message-ID: <20190126142854.GA20692@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+xP2SaJYD+OKC18y0zz2V6A9J8rAB0-cxMnrDmWt==8v2_uBA@mail.gmail.com>

On Sat, Jan 26, 2019 at 03:07:54PM +0100, Sebastian Staudt wrote:

> Are you sure that it will fail without a working tree?
> Is it even possible to have *no* working tree?
> 
> I already tested this with some real life examples, e.g.
> 
>     git --git-dir /some/path/.git describe
> 
> From inside and outside of other repositories.
> I didn‘t hit any errors so far.

Try:

  git clone --bare . bare.git
  cd bare.git
  git describe

That works with current versions of Git, but yields "fatal: this
operation must be run in a work tree" with your patch.

-Peff

PS Your patches seem whitespace-damaged. You might want to look into
   using git-send-email.

      reply	other threads:[~2019-01-26 14:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26 10:40 [PATCH 2/2] Setup working tree in describe Sebastian Staudt
2019-01-26 11:01 ` Duy Nguyen
2019-01-26 14:07   ` Sebastian Staudt
2019-01-26 14:28     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190126142854.GA20692@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=koraktor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).