From: Jeff King <peff@peff.net>
To: Sergey Lukashev <lukashev.s@ya.ru>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Junio C Hamano" <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: unclear docs
Date: Mon, 28 Jan 2019 15:46:21 -0500 [thread overview]
Message-ID: <20190128204621.GA15915@sigill.intra.peff.net> (raw)
In-Reply-To: <1811741548706614@myt1-06117f29c1ea.qloud-c.yandex.net>
On Mon, Jan 28, 2019 at 11:16:54PM +0300, Sergey Lukashev wrote:
> >> > Subject: [PATCH] doc/gitattributes: clarify "autocrlf overrides eol"
> >> >
> >> > We only override core.eol with core.autocrlf when the latter is set to
> >> > "true" (otherwise, core.eol would never do anything!). Let's make this
> >>
> >> I fail to understand what "otherwise..." wants to say. When
> >> core.autocrlf is not "true", core.eol would not do anything?
> >
> > I meant that if core.autocrlf overrides core.eol also when it is not set
> > to true, then there would be no way to use core.eol, because the former
> > must be either true or false.
>
> autocrlf can be "input" as well.
Ah, true. Should the documentation actually say "if core.autocrlf is not
'false'" then? I _think_ so from my reading of the code, but it would be
nice to have confirmation from somebody better versed in the line-ending
code than I am (+cc Torsten).
-Peff
prev parent reply other threads:[~2019-01-28 20:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 9:58 unclear docs Sergey Lukashev
2019-01-27 11:55 ` Sergey Lukashev
2019-01-28 16:09 ` Jeff King
2019-01-28 18:12 ` Sergey Lukashev
2019-01-28 18:31 ` Jeff King
2019-01-29 7:38 ` Torsten Bögershausen
2019-01-29 10:28 ` Sergey Lukashev
2019-01-29 12:40 ` [PATCH v2 0/2] eol/autocrlf doc clarifications Jeff King
2019-01-29 12:41 ` [PATCH v2 1/2] doc/gitattributes: clarify "autocrlf overrides eol" Jeff King
2019-01-29 12:41 ` [PATCH v2 2/2] docs/config: clarify "text property" in core.eol Jeff King
2019-01-28 17:31 ` unclear docs Torsten Bögershausen
2019-01-28 16:06 ` Jeff King
2019-01-28 18:30 ` Junio C Hamano
2019-01-28 18:32 ` Jeff King
2019-01-28 20:16 ` Sergey Lukashev
2019-01-28 20:46 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128204621.GA15915@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lukashev.s@ya.ru \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).