From: Jeff King <peff@peff.net>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Sergey Lukashev <lukashev.s@ya.ru>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: [PATCH v2 0/2] eol/autocrlf doc clarifications
Date: Tue, 29 Jan 2019 07:40:31 -0500 [thread overview]
Message-ID: <20190129124031.GA13084@sigill.intra.peff.net> (raw)
In-Reply-To: <20190129073810.23op5qaibyj2amwq@tb-raspi4>
On Tue, Jan 29, 2019 at 07:38:10AM +0000, Torsten Bögershausen wrote:
> > Yeah, I think the word "property" is unnecessarily confusing. Here's
> > another patch (meant to go on top of the other).
>
> The property was originally meant to say:
> - Either the "text" attribute is set in .gitattributes
> or
> - The "text=auto" attribute is set in .gitattributes and
> Git auto-detects the file as text (and not as binary).
Thanks, that makes it much more clear what the original was trying to
say.
> > + conversion. Note that this value is ignored if `core.autocrlf`
> > + is set to `true`.
>
> Should that be
> > + conversion. Note that this value is ignored if `core.autocrlf`
> > + is set to `true` or `input`.
Yes (and ditto in the other patch).
Here's a re-roll of both patches addressing these issues.
[1/2]: doc/gitattributes: clarify "autocrlf overrides eol"
[2/2]: docs/config: clarify "text property" in core.eol
Documentation/config/core.txt | 7 +++++--
Documentation/gitattributes.txt | 4 +++-
2 files changed, 8 insertions(+), 3 deletions(-)
-Peff
next prev parent reply other threads:[~2019-01-29 12:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 9:58 unclear docs Sergey Lukashev
2019-01-27 11:55 ` Sergey Lukashev
2019-01-28 16:09 ` Jeff King
2019-01-28 18:12 ` Sergey Lukashev
2019-01-28 18:31 ` Jeff King
2019-01-29 7:38 ` Torsten Bögershausen
2019-01-29 10:28 ` Sergey Lukashev
2019-01-29 12:40 ` Jeff King [this message]
2019-01-29 12:41 ` [PATCH v2 1/2] doc/gitattributes: clarify "autocrlf overrides eol" Jeff King
2019-01-29 12:41 ` [PATCH v2 2/2] docs/config: clarify "text property" in core.eol Jeff King
2019-01-28 17:31 ` unclear docs Torsten Bögershausen
2019-01-28 16:06 ` Jeff King
2019-01-28 18:30 ` Junio C Hamano
2019-01-28 18:32 ` Jeff King
2019-01-28 20:16 ` Sergey Lukashev
2019-01-28 20:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129124031.GA13084@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lukashev.s@ya.ru \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).