From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <dstolee@microsoft.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/1] Makefile: add prove and coverage-prove targets
Date: Tue, 29 Jan 2019 22:58:27 +0100 [thread overview]
Message-ID: <20190129215827.GF13764@szeder.dev> (raw)
In-Reply-To: <795f816d-d870-068a-5595-2fe617339a79@gmail.com>
On Tue, Jan 29, 2019 at 03:49:58PM -0500, Derrick Stolee wrote:
> On 1/29/2019 1:10 PM, Derrick Stolee wrote:
> > On 1/29/2019 12:34 PM, SZEDER Gábor wrote:
> >> On Tue, Jan 29, 2019 at 04:58:27PM +0100, SZEDER Gábor wrote:
> >> And in the related email discussion [1]:
> >>
> >> But even though the docs claim it [-j<N>] should be possible,
> >> I've been getting "random" test failures when compiled with coverage
> >> support, that went away with -j1. So the tests still run with -j1, as
> >> with the first version of the series.
> >>
> >> So it doesn't seem to be that bad after all, because it's not
> >> "completely breaks" but "random test failures". Still far from ideal,
> >> but the original coverage patch is just about 3 weeks short of a
> >> decade old, so maybe things have improved since then, and it'd be
> >> worth a try to leave GIT_PROVE_OPTS as is and see what happens.
> >
> > It would certainly be nice if the build time could be reduced through
> > parallel test runs. I've kicked off a build using GIT_PROVE_OPTS="-j12"
> > to see what happens.
>
> I did get a failed test with this run:
>
> t0025-crlf-renormalize.sh (Wstat: 256 Tests: 3 Failed: 1)
> Failed test: 2
> Non-zero exit status: 1
>
> This was on the 'jch' branch, and an equivalent build with sequential
> execution did not have this failure. That's flaky enough for me to stick
> to sequential runs.
That failure is not coverage-related, but as it turned out 9e5da3d055
(add: use separate ADD_CACHE_RENORMALIZE flag, 2019-01-17) made t0025
rather flaky:
https://public-inbox.org/git/20190129213533.GE13764@szeder.dev/
When reading those old commit messages and discussions in the
afternoon, I was wondering what "random test failures" actually meant,
since it was not stated explicitly that it was coverage-related. For
all we know it could have been "general" test flakiness that happened
to manifest under the higher load of a parallel test run.
next prev parent reply other threads:[~2019-01-29 21:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 14:56 [PATCH 0/1] Makefile: add prove and coverage-prove targets Derrick Stolee via GitGitGadget
2019-01-29 14:56 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2019-01-29 15:20 ` Johannes Schindelin
2019-01-29 15:58 ` SZEDER Gábor
2019-01-29 16:37 ` Derrick Stolee
2019-01-29 16:49 ` Jeff King
2019-01-29 17:34 ` SZEDER Gábor
2019-01-29 18:10 ` Derrick Stolee
2019-01-29 20:49 ` Derrick Stolee
2019-01-29 21:58 ` SZEDER Gábor [this message]
2019-01-29 16:00 ` Jeff King
2019-01-29 16:35 ` Derrick Stolee
2019-01-29 16:46 ` Jeff King
2019-01-29 21:03 ` Ævar Arnfjörð Bjarmason
2019-01-29 22:38 ` Jeff King
2019-01-30 12:20 ` Johannes Schindelin
2019-01-30 13:08 ` Ævar Arnfjörð Bjarmason
2019-01-30 18:42 ` Johannes Schindelin
2019-01-30 19:32 ` Ævar Arnfjörð Bjarmason
2019-01-31 7:23 ` Johannes Schindelin
2019-01-29 17:05 ` [PATCH v2 0/1] " Derrick Stolee via GitGitGadget
2019-01-29 17:05 ` [PATCH v2 1/1] Makefile: add coverage-prove target Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129215827.GF13764@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).