From: Jeff King <peff@peff.net>
To: Sebastian Staudt <koraktor@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH v3 2/3] Setup working tree in describe
Date: Wed, 30 Jan 2019 07:44:42 -0500 [thread overview]
Message-ID: <20190130124441.GB2273@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+xP2Sa9mSaBaYgY4LiAwaqX_YN75NV0qA=sTy0D6X1q=SjQeg@mail.gmail.com>
On Wed, Jan 30, 2019 at 11:31:15AM +0100, Sebastian Staudt wrote:
> > Yeah, my reasoning was that we handed off to diff-index, so if it
> > doesn't work, then it has its own bug. ;) But I agree it is probably
> > better to just be explicit.
>
> Thanks for that valuable feedback.
> Is there some trailer like "Co-authored-commit-message-by:"? ;)
We often say "Helped-by", but I am OK with or without that in this case.
To me, making suggestions like this is all just part of review. :)
-Peff
next prev parent reply other threads:[~2019-01-30 12:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 5:18 [PATCH v3 1/3] Add tests for describe with --work-tree Sebastian Staudt
2019-01-29 5:18 ` [PATCH v3 2/3] Setup working tree in describe Sebastian Staudt
2019-01-29 13:11 ` Jeff King
2019-01-29 17:39 ` Junio C Hamano
2019-01-29 20:53 ` Eric Sunshine
2019-01-29 22:35 ` Jeff King
2019-01-30 10:31 ` Sebastian Staudt
2019-01-30 12:44 ` Jeff King [this message]
2019-01-29 5:18 ` [PATCH v3 3/3] Add test for describe with a bare repository Sebastian Staudt
2019-01-29 13:12 ` Jeff King
2019-01-30 10:23 ` Sebastian Staudt
2019-01-29 13:00 ` [PATCH v3 1/3] Add tests for describe with --work-tree Jeff King
2019-01-29 17:47 ` Junio C Hamano
2019-01-30 10:23 ` Sebastian Staudt
2019-01-30 12:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130124441.GB2273@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=koraktor@gmail.com \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).