git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] test-date: drop unused parameter to getnanos()
@ 2019-02-06 19:35 Jeff King
  0 siblings, 0 replies; only message in thread
From: Jeff King @ 2019-02-06 19:35 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: Junio C Hamano, git

The getnanos() helper always gets the current time from our
getnanotime() facility. The caller cannot override it via TEST_DATE_NOW,
and hence we simply ignore the "now" parameter to the function. Let's
remove it, as it may mislead callers into thinking it does something.

Signed-off-by: Jeff King <peff@peff.net>
---
This goes on the js/vsts-ci branch.

Noticed by merging 'next' with my -Wunused-parameters work-in-progress. :)

 t/helper/test-date.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/helper/test-date.c b/t/helper/test-date.c
index 792a805374..f9e2b91ed1 100644
--- a/t/helper/test-date.c
+++ b/t/helper/test-date.c
@@ -83,7 +83,7 @@ static void parse_approx_timestamp(const char **argv, struct timeval *now)
 	}
 }
 
-static void getnanos(const char **argv, struct timeval *now)
+static void getnanos(const char **argv)
 {
 	double seconds = getnanotime() / 1.0e9;
 
@@ -119,7 +119,7 @@ int cmd__date(int argc, const char **argv)
 	else if (!strcmp(*argv, "timestamp"))
 		parse_approx_timestamp(argv+1, &now);
 	else if (!strcmp(*argv, "getnanos"))
-		getnanos(argv+1, &now);
+		getnanos(argv+1);
 	else if (!strcmp(*argv, "is64bit"))
 		return sizeof(timestamp_t) == 8 ? 0 : 1;
 	else if (!strcmp(*argv, "time_t-is64bit"))
-- 
2.20.1.1122.g2972e48916

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-02-06 19:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-06 19:35 [PATCH] test-date: drop unused parameter to getnanos() Jeff King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).