From: Jeff King <peff@peff.net>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: git@vger.kernel.org, 'Duy Nguyen' <pclouds@gmail.com>
Subject: Re: [Possible Breakage] t1308 - Bad return value from test-tool
Date: Fri, 8 Feb 2019 23:24:04 -0500 [thread overview]
Message-ID: <20190209042404.GA18286@sigill.intra.peff.net> (raw)
In-Reply-To: <004901d4bff7$2e17dc50$8a4794f0$@nexbridge.com>
On Fri, Feb 08, 2019 at 04:42:19PM -0500, Randall S. Becker wrote:
> t1308 has me perplexed - this is an old breakage on the NonStop platform,
> that I have just gotten around to checking with the new bash version we
> have. When running sub-test 23, the following was reported:
>
> Value not found for "foo.bar"
> test_expect_code: command exited with 1, we wanted 2 test-tool config
> configset_get_value foo.bar a-directory
>
> However, when I looked inside t/helper/test-config.c, every path reporting
> "Value not found" has a goto exit1 not exit2. It seems, from the code, that
> the test is actually incorrect and should be expecting 1 not 2, and that it
> is working properly on NonStop (but the test fails as a result).
We're expecting it to report an error reading the directory, not "value
not found". Which would yield code 2.
It sounds like you might need to set FREAD_READS_DIRECTORIES in your
config.mak.
-Peff
next prev parent reply other threads:[~2019-02-09 4:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 21:42 [Possible Breakage] t1308 - Bad return value from test-tool Randall S. Becker
2019-02-09 4:24 ` Jeff King [this message]
2019-02-09 18:08 ` Randall S. Becker
2019-02-09 23:32 ` Jeff King
2019-02-10 0:15 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209042404.GA18286@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).